Skip to content

chore(toolbox-core): Use Toolbox server dev build for integration tests #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(toolbox-core): Use Toolbox server dev build for integration tests #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2520768
chore: Test integration test with main branch
anubhav756 Jul 1, 2025
e4da96b
chore: Delint
anubhav756 Jul 1, 2025
14d805b
fix: Fix toolbox download version 'v' prefix
anubhav756 Jul 1, 2025
277bdb9
fix: Update the toolbox version tag to pick the dev builds from
anubhav756 Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/toolbox-core/integration.cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ steps:
env:
- TOOLBOX_URL=$_TOOLBOX_URL
- TOOLBOX_VERSION=$_TOOLBOX_VERSION
- TOOLBOX_BUCKET=$_TOOLBOX_BUCKET
- GOOGLE_CLOUD_PROJECT=$PROJECT_ID
args:
- '-c'
Expand All @@ -43,4 +44,5 @@ options:
logging: CLOUD_LOGGING_ONLY
substitutions:
_VERSION: '3.13'
_TOOLBOX_VERSION: '0.8.0'
_TOOLBOX_VERSION: 'latest'
_TOOLBOX_BUCKET: 'genai-toolbox-dev'
13 changes: 10 additions & 3 deletions packages/toolbox-core/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def get_toolbox_binary_url(toolbox_version: str) -> str:
arch = (
"arm64" if os_system == "darwin" and platform.machine() == "arm64" else "amd64"
)
return f"v{toolbox_version}/{os_system}/{arch}/toolbox"
return f"{toolbox_version}/{os_system}/{arch}/toolbox"


def get_auth_token(client_id: str) -> str:
Expand All @@ -102,6 +102,11 @@ def toolbox_version() -> str:
return get_env_var("TOOLBOX_VERSION")


@pytest_asyncio.fixture(scope="session")
def toolbox_bucket() -> str:
return get_env_var("TOOLBOX_BUCKET")


@pytest_asyncio.fixture(scope="session")
def tools_file_path(project_id: str) -> Generator[str]:
"""Provides a temporary file path containing the tools manifest."""
Expand Down Expand Up @@ -130,11 +135,13 @@ def auth_token2(project_id: str) -> str:


@pytest_asyncio.fixture(scope="session")
def toolbox_server(toolbox_version: str, tools_file_path: str) -> Generator[None]:
def toolbox_server(
toolbox_version: str, toolbox_bucket: str, tools_file_path: str
) -> Generator[None]:
"""Starts the toolbox server as a subprocess."""
print("Downloading toolbox binary from gcs bucket...")
source_blob_name = get_toolbox_binary_url(toolbox_version)
download_blob("genai-toolbox", source_blob_name, "toolbox")
download_blob(toolbox_bucket, source_blob_name, "toolbox")
print("Toolbox binary downloaded successfully.")
try:
print("Opening toolbox server process...")
Expand Down