Skip to content

Commit 1e3a528

Browse files
stephenpluspluscallmehiphop
authored andcommitted
all modules: ensure all User-Agents are set (#1568)
1 parent e0cd052 commit 1e3a528

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"datastore"
5151
],
5252
"dependencies": {
53-
"@google-cloud/common": "^0.4.0",
53+
"@google-cloud/common": "^0.5.0",
5454
"arrify": "^1.0.0",
5555
"concat-stream": "^1.5.0",
5656
"create-error-class": "^3.0.2",

src/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ var Query = require('./query.js');
4949
*/
5050
var Transaction = require('./transaction.js');
5151

52-
var PKG = require('../package.json');
53-
5452
/**
5553
* @constructor
5654
* @alias module:datastore
@@ -323,7 +321,7 @@ function Datastore(options) {
323321
service: 'datastore',
324322
apiVersion: 'v1',
325323
scopes: ['https://www.googleapis.com/auth/datastore'],
326-
userAgent: PKG.name + '/' + PKG.version,
324+
packageJson: require('../package.json'),
327325
grpcMetadata: {
328326
'google-cloud-resource-prefix': 'projects/' + this.projectId
329327
}

test/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ var extend = require('extend');
2121
var proxyquire = require('proxyquire');
2222
var util = require('@google-cloud/common').util;
2323

24-
var PKG = require('../package.json');
25-
2624
var fakeEntity = {
2725
Int: function(value) {
2826
this.value = value;
@@ -157,7 +155,7 @@ describe('Datastore', function() {
157155
assert.deepEqual(calledWith.scopes, [
158156
'https://www.googleapis.com/auth/datastore'
159157
]);
160-
assert.strictEqual(calledWith.userAgent, PKG.name + '/' + PKG.version);
158+
assert.deepEqual(calledWith.packageJson, require('../package.json'));
161159
assert.deepEqual(calledWith.grpcMetadata, {
162160
'google-cloud-resource-prefix': 'projects/' + datastore.projectId
163161
});

0 commit comments

Comments
 (0)