chore: remove the blob error workaround (#1072)

* remove the blob error workaround

An error with code 3 was thrown when the test code was run before the workaround was added and before the proto changes were made. Now that the proto changes have been made, the workaround is no longer required so it is removed in this commit.

* return encode test to original

Change a test so that it matches what it originally was back in 2020.

Author: danieljbruce

src/entity.ts

@@ -657,10 +657,7 @@ export namespace entity {
     }
 
     if (value instanceof Buffer) {
-      // Convert the buffer to a base 64 string to workaround a bug of
-      // protobufs encoding empty buffer.
-      // See https://github.com/googleapis/nodejs-datastore/issues/755
-      valueProto.blobValue = value.toString('base64');
+      valueProto.blobValue = value;
       return valueProto;
     }
 

system-test/datastore.ts

@@ -543,6 +543,19 @@ describe('Datastore', () => {
       await datastore.delete(personKey);
     });
 
+    it('should save with an empty buffer', async () => {
+      const key = datastore.key(['TEST']);
+      const result = await datastore.save({
+        key: key,
+        data: {
+          name: 'test',
+          blob: Buffer.from([]),
+        },
+      });
+      const mutationResult = result.pop()?.mutationResults?.pop();
+      assert.strictEqual(mutationResult?.key?.path?.pop()?.kind, 'TEST');
+    });
+
     describe('entity types', () => {
       it('should save and decode an int', async () => {
         const integerValue = 2015;

test/entity.ts

@@ -849,7 +849,7 @@ describe('entity', () => {
       const value = Buffer.from('Hi');
 
       const expectedValueProto = {
-        blobValue: value.toString('base64'),
+        blobValue: value,
       };
 
       assert.deepStrictEqual(entity.encodeValue(value), expectedValueProto);