chore(filter): Add a switch statement (#1108)

* Add a switch statement

In the filter function a switch statement is added so that it is clear to the reader what happens when the arguments are of various lengths

* chore(filter): Add a switch statement

* code review suggestions

Remove the else block, it should never happen anyway because if it does then the user is misusing the function

Author: danieljbruce

src/query.ts

@@ -222,24 +222,33 @@ class Query {
     operatorOrValue?: Operator | AllowedFilterValueType<T>,
     value?: AllowedFilterValueType<T>
   ): Query {
-    if (isFilter(propertyOrFilter)) {
-      this.entityFilters.push(propertyOrFilter);
-      return this;
-    } else {
+    if (arguments.length > 1) {
       process.emitWarning(
         'Providing Filter objects like Composite Filter or Property Filter is recommended when using .filter'
       );
-      let operator = operatorOrValue as Operator;
-      if (arguments.length === 2) {
-        value = operatorOrValue as AllowedFilterValueType<T>;
-        operator = '=';
+    }
+    switch (arguments.length) {
+      case 1: {
+        if (isFilter(propertyOrFilter)) {
+          this.entityFilters.push(propertyOrFilter);
+        }
+        break;
+      }
+      case 2: {
+        this.filters.push({
+          name: (propertyOrFilter as String).trim(),
+          op: '=',
+          val: operatorOrValue as AllowedFilterValueType<T>,
+        });
+        break;
+      }
+      case 3: {
+        this.filters.push({
+          name: (propertyOrFilter as String).trim(),
+          op: (operatorOrValue as Operator).trim() as Operator,
+          val: value,
+        });
       }
-
-      this.filters.push({
-        name: (propertyOrFilter as String).trim(),
-        op: operator.trim() as Operator,
-        val: value,
-      });
     }
     return this;
   }