Skip to content

Commit bb2ff12

Browse files
ericuldallcallmehiphop
authored andcommitted
updated FQDN's to googleapis.com with a trailing dot (#2214)
1 parent 059a321 commit bb2ff12

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ function Datastore(options) {
300300
return new Datastore(options);
301301
}
302302

303-
this.defaultBaseUrl_ = 'datastore.googleapis.com';
303+
this.defaultBaseUrl_ = 'datastore.googleapis.com.';
304304
this.determineBaseUrl_(options.apiEndpoint);
305305

306306
this.namespace = options.namespace;

src/v1/datastore_client.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,4 +500,4 @@ function DatastoreClientBuilder(gaxGrpc) {
500500
}
501501
module.exports = DatastoreClientBuilder;
502502
module.exports.SERVICE_ADDRESS = SERVICE_ADDRESS;
503-
module.exports.ALL_SCOPES = ALL_SCOPES;
503+
module.exports.ALL_SCOPES = ALL_SCOPES;

test/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,10 @@ describe('Datastore', function() {
116116
});
117117

118118
it('should set the default base URL', function() {
119-
assert.strictEqual(datastore.defaultBaseUrl_, 'datastore.googleapis.com');
119+
assert.strictEqual(
120+
datastore.defaultBaseUrl_,
121+
'datastore.googleapis.com.'
122+
);
120123
});
121124

122125
it('should set default API connection details', function(done) {

0 commit comments

Comments
 (0)