Skip to content

Commit 3d61340

Browse files
authored
fix: Export regexFind and regexFindAll functions to public API (#2492)
Follow up to #2474. The `regexFind` and `regexFindAll` standalone expression functions were not exported to the public API by mistake. This PR exports them to the public API and updates the import path in the tests.
1 parent 4155a55 commit 3d61340

File tree

3 files changed

+30
-1
lines changed

3 files changed

+30
-1
lines changed

api-report/firestore.api.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1845,6 +1845,8 @@ declare namespace Pipelines {
18451845
or,
18461846
regexContains,
18471847
regexMatch,
1848+
regexFind,
1849+
regexFindAll,
18481850
startsWith,
18491851
stringConcat,
18501852
subtract,
@@ -2283,6 +2285,30 @@ function regexContains(stringExpression: Expression, pattern: string): BooleanEx
22832285
// @beta
22842286
function regexContains(stringExpression: Expression, pattern: Expression): BooleanExpression;
22852287

2288+
// @beta
2289+
function regexFind(fieldName: string, pattern: string): FunctionExpression;
2290+
2291+
// @beta
2292+
function regexFind(fieldName: string, pattern: Expression): FunctionExpression;
2293+
2294+
// @beta
2295+
function regexFind(stringExpression: Expression, pattern: string): FunctionExpression;
2296+
2297+
// @beta
2298+
function regexFind(stringExpression: Expression, pattern: Expression): FunctionExpression;
2299+
2300+
// @beta
2301+
function regexFindAll(fieldName: string, pattern: string): FunctionExpression;
2302+
2303+
// @beta
2304+
function regexFindAll(fieldName: string, pattern: Expression): FunctionExpression;
2305+
2306+
// @beta
2307+
function regexFindAll(stringExpression: Expression, pattern: string): FunctionExpression;
2308+
2309+
// @beta
2310+
function regexFindAll(stringExpression: Expression, pattern: Expression): FunctionExpression;
2311+
22862312
// @beta
22872313
function regexMatch(fieldName: string, pattern: string): BooleanExpression;
22882314

dev/src/pipelines/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ export {
3838
or,
3939
regexContains,
4040
regexMatch,
41+
regexFind,
42+
regexFindAll,
4143
startsWith,
4244
stringConcat,
4345
subtract,

dev/system-test/pipeline.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ import {
8282
or,
8383
regexContains,
8484
regexMatch,
85+
regexFind,
86+
regexFindAll,
8587
startsWith,
8688
stringConcat,
8789
subtract,
@@ -145,7 +147,6 @@ import {getTestDb, getTestRoot} from './firestore';
145147

146148
import {Firestore as InternalFirestore} from '../src';
147149
import {ServiceError} from 'google-gax';
148-
import {regexFind, regexFindAll} from '../src/pipelines/expression';
149150

150151
use(chaiAsPromised);
151152

0 commit comments

Comments
 (0)