samples: fix linting and typelessing of samples

Author: feywind

package.json

@@ -45,9 +45,7 @@
     "predocs-test": "npm run docs",
     "benchwrapper": "node bin/benchwrapper.js",
     "prelint": "cd samples; npm link ../; npm install",
-    "precompile": "gts clean",
-    "typeless": "npx typeless-sample-bot --outputpath samples --targets samples --recursive",
-    "posttypeless": "npm run link-samples && npx eslint --ignore-pattern owl-bot-staging --fix samples"
+    "precompile": "gts clean"
   },
   "dependencies": {
     "@google-cloud/paginator": "^6.0.0",
@@ -66,7 +64,6 @@
     "p-defer": "^3.0.0"
   },
   "devDependencies": {
-    "@google-cloud/typeless-sample-bot": "^3.0.0",
     "@grpc/proto-loader": "^0.7.13",
     "@opentelemetry/core": "^1.17.0",
     "@opentelemetry/sdk-trace-base": "^1.17.0",

samples/createTopic.js

@@ -48,7 +48,7 @@ async function createTopic(topicNameOrId) {
 }
 // [END pubsub_create_topic]
 
-async function main(topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID') {
+function main(topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID') {
   createTopic(topicNameOrId).catch(err => {
     console.error(err.message);
     process.exitCode = 1;

samples/listenWithCustomAttributes.js

@@ -66,7 +66,7 @@ async function listenWithCustomAttributes(subscriptionNameOrId, timeout) {
 }
 // [END pubsub_subscriber_async_pull_custom_attributes]
 
-async function main(
+function main(
   subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID',
   timeout = 60,
 ) {

samples/package.json

@@ -18,7 +18,10 @@
     "sampletsc": "cd typescript && tsc -p . && cd ..",
     "compile": "npm run tsc && npm run sampletsc",
     "clean": "gts clean && rm -rf build/",
-    "precompile": "npm run clean"
+    "precompile": "npm run clean",
+    "pretypeless": "npx eslint --fix typescript/*.ts",
+    "typeless": "npx typeless-sample-bot --outputpath . --targets typescript --recursive",
+    "posttypeless": "npx eslint --fix *.js"
   },
   "dependencies": {
     "@google-cloud/opentelemetry-cloud-trace-exporter": "^2.0.0",
@@ -35,6 +38,7 @@
   },
   "devDependencies": {
     "@google-cloud/bigquery": "^7.0.0",
+    "@google-cloud/typeless-sample-bot": "^3.0.0",
     "@types/chai": "^4.2.16",
     "chai": "^4.2.0",
     "gts": "^5.0.0",

samples/publishOrderedMessage.js

@@ -80,12 +80,12 @@ async function publishOrderedMessage(topicNameOrId, data, orderingKey) {
 }
 // [END pubsub_publish_with_ordering_keys]
 
-async function main(
+function main(
   topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID',
   data = JSON.stringify({foo: 'bar'}),
   orderingKey = 'key1',
 ) {
-  await publishOrderedMessage(topicNameOrId, data, orderingKey).catch(err => {
+  publishOrderedMessage(topicNameOrId, data, orderingKey).catch(err => {
     console.error(err.message);
     process.exitCode = 1;
   });

samples/quickstart.js

@@ -55,12 +55,11 @@ async function quickstart(
   });
 
   // Send a message to the topic
-  topic.publishMessage({data: Buffer.from('Test message!')});
+  await topic.publishMessage({data: Buffer.from('Test message!')});
 }
 // [END pubsub_quickstart_create_topic]
 
-process.on('unhandledRejection', err => {
+quickstart(...process.argv.slice(2)).catch(err => {
   console.error(err.message);
   process.exitCode = 1;
 });
-quickstart(...process.argv.slice(2));

samples/subscribeWithFlowControlSettings.js

@@ -79,8 +79,8 @@ async function subscribeWithFlowControlSettings(
   subscription.on('message', messageHandler);
 
   // Wait a while for the subscription to run. (Part of the sample only.)
-  setTimeout(() => {
-    subscription.close();
+  setTimeout(async () => {
+    await subscription.close();
   }, timeout * 1000);
 }
 // [END pubsub_subscriber_flow_settings]

samples/typescript/createTopic.ts

@@ -44,7 +44,7 @@ async function createTopic(topicNameOrId: string) {
 }
 // [END pubsub_create_topic]
 
-async function main(topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID') {
+function main(topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID') {
   createTopic(topicNameOrId).catch(err => {
     console.error(err.message);
     process.exitCode = 1;

samples/typescript/listenWithCustomAttributes.ts

@@ -65,7 +65,7 @@ async function listenWithCustomAttributes(
 }
 // [END pubsub_subscriber_async_pull_custom_attributes]
 
-async function main(
+function main(
   subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID',
   timeout = 60,
 ) {

samples/typescript/publishOrderedMessage.ts

@@ -80,12 +80,12 @@ async function publishOrderedMessage(
 }
 // [END pubsub_publish_with_ordering_keys]
 
-async function main(
+function main(
   topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID',
   data = JSON.stringify({foo: 'bar'}),
   orderingKey = 'key1',
 ) {
-  await publishOrderedMessage(topicNameOrId, data, orderingKey).catch(err => {
+  publishOrderedMessage(topicNameOrId, data, orderingKey).catch(err => {
     console.error(err.message);
     process.exitCode = 1;
   });