Skip to content

Commit 77aa8ff

Browse files
committed
review comments
1 parent ed33f37 commit 77aa8ff

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

samples/observability-traces-otlp.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,10 @@ async function main(
3030
const {
3131
OTLPTraceExporter,
3232
} = require('@opentelemetry/exporter-trace-otlp-grpc');
33-
const {BatchSpanProcessor} = require('@opentelemetry/sdk-trace-base');
34-
const {TraceIdRatioBasedSampler} = require('@opentelemetry/sdk-trace-base');
33+
const {
34+
BatchSpanProcessor,
35+
TraceIdRatioBasedSampler,
36+
} = require('@opentelemetry/sdk-trace-base');
3537
const {Resource} = require('@opentelemetry/resources');
3638
const {Spanner} = require('@google-cloud/spanner');
3739

@@ -53,7 +55,7 @@ async function main(
5355
spanProcessors: [new BatchSpanProcessor(traceExporter)],
5456
});
5557

56-
// Uncomment following line to register tracerProvider globally
58+
// Uncomment following line to register tracerProvider globally or pass it in Spanner object
5759
// provider.register();
5860

5961
// Create the Cloud Spanner Client.

samples/observability-traces.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,10 @@ async function main(
3131
const {
3232
TraceExporter,
3333
} = require('@google-cloud/opentelemetry-cloud-trace-exporter');
34-
const {BatchSpanProcessor} = require('@opentelemetry/sdk-trace-base');
35-
const {TraceIdRatioBasedSampler} = require('@opentelemetry/sdk-trace-base');
34+
const {
35+
BatchSpanProcessor,
36+
TraceIdRatioBasedSampler,
37+
} = require('@opentelemetry/sdk-trace-base');
3638
const {Spanner} = require('@google-cloud/spanner');
3739

3840
const traceExporter = new TraceExporter();

0 commit comments

Comments
 (0)