Skip to content

Commit aa0672f

Browse files
committed
review comments
1 parent f30ce4b commit aa0672f

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/index.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -497,9 +497,7 @@ class Spanner extends GrpcService {
497497
ensureInitialContextManagerSet();
498498
this._nthClientId = nextSpannerClientId();
499499
this._universeDomain = universeEndpoint;
500-
this.configureMetrics_(
501-
options.disableBuiltInMetrics ? options.disableBuiltInMetrics : false,
502-
);
500+
this.configureMetrics_(options.disableBuiltInMetrics);
503501
}
504502

505503
get universeDomain() {
@@ -1618,10 +1616,10 @@ class Spanner extends GrpcService {
16181616
/**
16191617
* Setup the OpenTelemetry metrics capturing for service metrics to Google Cloud Monitoring.
16201618
*/
1621-
configureMetrics_(disableBuiltInMetrics: boolean) {
1619+
configureMetrics_(disableBuiltInMetrics?: boolean) {
16221620
const metricsEnabled =
16231621
process.env.SPANNER_DISABLE_BUILTIN_METRICS !== 'true' &&
1624-
disableBuiltInMetrics !== true &&
1622+
!disableBuiltInMetrics &&
16251623
this.options.credentials === grpc.credentials.createInsecure();
16261624
MetricsTracerFactory.enabled = metricsEnabled;
16271625
if (metricsEnabled) {

0 commit comments

Comments
 (0)