chore: Add Custom OpenTelemetry Exporter in for Service Metrics#2270
Closed
ravjotbrar wants to merge 3 commits intogoogleapis:mainfrom
Closed
chore: Add Custom OpenTelemetry Exporter in for Service Metrics#2270ravjotbrar wants to merge 3 commits intogoogleapis:mainfrom
ravjotbrar wants to merge 3 commits intogoogleapis:mainfrom
Conversation
Contributor
|
Looking to resolve the CI failures on older node versions. Will see if I can reduce usage of the new packages |
6 tasks
Contributor
|
Please close this as edits/changes are being handled in #2272 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds an implementation for an OpenTelemetry exporter to send the following service metrics that are already present in the Python, Go and Java clients:
operation_latencies
operation_count
attempt_latencies
attempt_count
gfe_latency
gfe_missing_header_count
Files added to a metrics folder in /src/metrics/ folder:
constants.ts - Constant values such as metric and label names to be used by both the exporter and eventual implementing code.
spanner-metrics-exporter.ts - The definition for the exporter
external-types.ts - Type definition for ExporterOptions, MetricKind, and ValueType
transform.ts - Methods that help create a GCM timeseries list from scope metrics.
Based on regular client Google Cloud Monitoring exporter found here
Impact
Integrates Built-in Metrics support into Node.js spanner client library.
Testing
Unit tests were added in /test/metrics
Checklist
Fixes #issue_number_goes_here 🦕