Skip to content

Commit 30f405a

Browse files
yeesiancopybara-github
authored andcommitted
fix: mistyping of langchain tools causing mypy errors
PiperOrigin-RevId: 855234813
1 parent b814aab commit 30f405a

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

vertexai/agent_engines/templates/langchain.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
Iterable,
2222
Mapping,
2323
Optional,
24-
Sequence,
2524
Union,
2625
)
2726

@@ -46,9 +45,9 @@
4645
try:
4746
from langchain_google_vertexai.functions_utils import _ToolsType
4847

49-
_ToolLike = _ToolsType
48+
_ToolsType = _ToolsType
5049
except ImportError:
51-
_ToolLike = Any
50+
_ToolsType = Any
5251

5352
try:
5453
from opentelemetry.sdk import trace
@@ -116,7 +115,7 @@ def _default_runnable_builder(
116115
model: "BaseLanguageModel",
117116
*,
118117
system_instruction: Optional[str] = None,
119-
tools: Optional[Sequence["_ToolLike"]] = None,
118+
tools: Optional["_ToolsType"] = None,
120119
prompt: Optional["RunnableSerializable"] = None,
121120
output_parser: Optional["RunnableSerializable"] = None,
122121
chat_history: Optional["GetSessionHistoryCallable"] = None,
@@ -320,7 +319,7 @@ def _validate_callable_parameters_are_annotated(callable: Callable):
320319
)
321320

322321

323-
def _validate_tools(tools: Sequence["_ToolLike"]):
322+
def _validate_tools(tools: "_ToolsType"):
324323
"""Validates that the tools are usable for tool calling."""
325324
for tool in tools:
326325
if isinstance(tool, Callable):
@@ -370,7 +369,7 @@ def __init__(
370369
*,
371370
system_instruction: Optional[str] = None,
372371
prompt: Optional["RunnableSerializable"] = None,
373-
tools: Optional[Sequence["_ToolLike"]] = None,
372+
tools: Optional["_ToolsType"] = None,
374373
output_parser: Optional["RunnableSerializable"] = None,
375374
chat_history: Optional["GetSessionHistoryCallable"] = None,
376375
model_kwargs: Optional[Mapping[str, Any]] = None,

vertexai/preview/reasoning_engines/templates/langchain.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
Iterable,
2222
Mapping,
2323
Optional,
24-
Sequence,
2524
Union,
2625
)
2726

@@ -46,9 +45,9 @@
4645
try:
4746
from langchain_google_vertexai.functions_utils import _ToolsType
4847

49-
_ToolLike = _ToolsType
48+
_ToolsType = _ToolsType
5049
except ImportError:
51-
_ToolLike = Any
50+
_ToolsType = Any
5251

5352
try:
5453
from opentelemetry.sdk import trace
@@ -116,7 +115,7 @@ def _default_runnable_builder(
116115
model: "BaseLanguageModel",
117116
*,
118117
system_instruction: Optional[str] = None,
119-
tools: Optional[Sequence["_ToolLike"]] = None,
118+
tools: Optional["_ToolsType"] = None,
120119
prompt: Optional["RunnableSerializable"] = None,
121120
output_parser: Optional["RunnableSerializable"] = None,
122121
chat_history: Optional["GetSessionHistoryCallable"] = None,
@@ -234,7 +233,7 @@ def _validate_callable_parameters_are_annotated(callable: Callable):
234233
)
235234

236235

237-
def _validate_tools(tools: Sequence["_ToolLike"]):
236+
def _validate_tools(tools: "_ToolsType"):
238237
"""Validates that the tools are usable for tool calling."""
239238
for tool in tools:
240239
if isinstance(tool, Callable):
@@ -284,7 +283,7 @@ def __init__(
284283
*,
285284
system_instruction: Optional[str] = None,
286285
prompt: Optional["RunnableSerializable"] = None,
287-
tools: Optional[Sequence["_ToolLike"]] = None,
286+
tools: Optional["_ToolsType"] = None,
288287
output_parser: Optional["RunnableSerializable"] = None,
289288
chat_history: Optional["GetSessionHistoryCallable"] = None,
290289
model_kwargs: Optional[Mapping[str, Any]] = None,

0 commit comments

Comments
 (0)