Skip to content

Commit cb188d4

Browse files
committed
fix: always create TreeAhConfig in create_tree_ah_index()
Fixes #6222
1 parent cffa558 commit cb188d4

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

google/cloud/aiplatform/matching_engine/matching_engine_index.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -596,15 +596,10 @@ def create_tree_ah_index(
596596
597597
"""
598598

599-
algorithm_config = None
600-
if (
601-
leaf_node_embedding_count is not None
602-
or leaf_nodes_to_search_percent is not None
603-
):
604-
algorithm_config = matching_engine_index_config.TreeAhConfig(
605-
leaf_node_embedding_count=leaf_node_embedding_count,
606-
leaf_nodes_to_search_percent=leaf_nodes_to_search_percent,
607-
)
599+
algorithm_config = matching_engine_index_config.TreeAhConfig(
600+
leaf_node_embedding_count=leaf_node_embedding_count,
601+
leaf_nodes_to_search_percent=leaf_nodes_to_search_percent,
602+
)
608603

609604
config = matching_engine_index_config.MatchingEngineIndexConfig(
610605
dimensions=dimensions,

tests/unit/aiplatform/test_matching_engine_index.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,12 @@ def test_create_tree_ah_index_empty_algorithm_config(self, create_index_mock):
637637
display_name=_TEST_INDEX_DISPLAY_NAME,
638638
metadata={
639639
"config": {
640-
"algorithmConfig": None,
640+
"algorithmConfig": {
641+
"treeAhConfig": {
642+
"leafNodeEmbeddingCount": None,
643+
"leafNodesToSearchPercent": None,
644+
}
645+
},
641646
"dimensions": _TEST_INDEX_CONFIG_DIMENSIONS,
642647
"approximateNeighborsCount": _TEST_INDEX_APPROXIMATE_NEIGHBORS_COUNT,
643648
"distanceMeasureType": _TEST_INDEX_DISTANCE_MEASURE_TYPE,

0 commit comments

Comments
 (0)