From cb188d4810b8a3450e6cd2976d86e3ec7f0bd631 Mon Sep 17 00:00:00 2001 From: taimo3810 Date: Sat, 3 Jan 2026 18:25:23 +0900 Subject: [PATCH 1/2] fix: always create TreeAhConfig in create_tree_ah_index() Fixes #6222 --- .../matching_engine/matching_engine_index.py | 13 ++++--------- tests/unit/aiplatform/test_matching_engine_index.py | 7 ++++++- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/google/cloud/aiplatform/matching_engine/matching_engine_index.py b/google/cloud/aiplatform/matching_engine/matching_engine_index.py index 7922cba7e1..b5a521d1e1 100644 --- a/google/cloud/aiplatform/matching_engine/matching_engine_index.py +++ b/google/cloud/aiplatform/matching_engine/matching_engine_index.py @@ -596,15 +596,10 @@ def create_tree_ah_index( """ - algorithm_config = None - if ( - leaf_node_embedding_count is not None - or leaf_nodes_to_search_percent is not None - ): - algorithm_config = matching_engine_index_config.TreeAhConfig( - leaf_node_embedding_count=leaf_node_embedding_count, - leaf_nodes_to_search_percent=leaf_nodes_to_search_percent, - ) + algorithm_config = matching_engine_index_config.TreeAhConfig( + leaf_node_embedding_count=leaf_node_embedding_count, + leaf_nodes_to_search_percent=leaf_nodes_to_search_percent, + ) config = matching_engine_index_config.MatchingEngineIndexConfig( dimensions=dimensions, diff --git a/tests/unit/aiplatform/test_matching_engine_index.py b/tests/unit/aiplatform/test_matching_engine_index.py index c8929366b5..5b9ac15155 100644 --- a/tests/unit/aiplatform/test_matching_engine_index.py +++ b/tests/unit/aiplatform/test_matching_engine_index.py @@ -637,7 +637,12 @@ def test_create_tree_ah_index_empty_algorithm_config(self, create_index_mock): display_name=_TEST_INDEX_DISPLAY_NAME, metadata={ "config": { - "algorithmConfig": None, + "algorithmConfig": { + "treeAhConfig": { + "leafNodeEmbeddingCount": None, + "leafNodesToSearchPercent": None, + } + }, "dimensions": _TEST_INDEX_CONFIG_DIMENSIONS, "approximateNeighborsCount": _TEST_INDEX_APPROXIMATE_NEIGHBORS_COUNT, "distanceMeasureType": _TEST_INDEX_DISTANCE_MEASURE_TYPE, From 25b981b2f94c2ec1480ffecebf73ffd126c05c7d Mon Sep 17 00:00:00 2001 From: taimo3810 Date: Sat, 10 Jan 2026 21:53:41 +0900 Subject: [PATCH 2/2] chore: trigger CI