address PR feedback

Author: ohmayr

google/api_core/client_logging.py

@@ -1,8 +1,9 @@
 import logging
 import json
-import re
 import os
 
+from typing import List, Optional
+
 _LOGGING_INITIALIZED = False
 _BASE_LOGGER_NAME = "google"
 # TODO(https://github.com/googleapis/python-api-core/issues/760): Update Request / Response messages.
@@ -19,9 +20,7 @@
 
 def logger_configured(logger):
     return (
-        logger.handlers != []
-        or logger.level != logging.NOTSET
-        or logger.propagate == False
+        logger.handlers != [] or logger.level != logging.NOTSET or not logger.propagate
     )
 
 
@@ -34,7 +33,7 @@ def initialize_logging():
     _LOGGING_INITIALIZED = True
 
 
-def parse_logging_scopes(scopes):
+def parse_logging_scopes(scopes: Optional[str] = None) -> List[str]:
     if not scopes:
         return []
     # TODO(https://github.com/googleapis/python-api-core/issues/759): check if the namespace is a valid namespace.

tests/unit/test_client_logging.py

@@ -1,6 +1,5 @@
 import logging
-import pytest
-import mock
+from unittest import mock
 
 from google.api_core.client_logging import (
     setup_logging,
@@ -20,7 +19,7 @@ def test_setup_logging_w_no_scopes():
         setup_logging()
         base_logger = logging.getLogger("foo")
         assert base_logger.handlers == []
-        assert base_logger.propagate == False
+        assert not base_logger.propagate
         assert base_logger.level == logging.NOTSET
 
     reset_logger("foo")
@@ -31,7 +30,7 @@ def test_setup_logging_w_base_scope():
         setup_logging("foo")
     base_logger = logging.getLogger("foo")
     assert isinstance(base_logger.handlers[0], logging.StreamHandler)
-    assert base_logger.propagate == False
+    assert not base_logger.propagate
     assert base_logger.level == logging.DEBUG
 
     reset_logger("foo")
@@ -43,12 +42,12 @@ def test_setup_logging_w_module_scope():
 
     base_logger = logging.getLogger("foo")
     assert base_logger.handlers == []
-    assert base_logger.propagate == False
+    assert not base_logger.propagate
     assert base_logger.level == logging.NOTSET
 
     module_logger = logging.getLogger("foo.bar")
     assert isinstance(module_logger.handlers[0], logging.StreamHandler)
-    assert module_logger.propagate == False
+    assert not module_logger.propagate
     assert module_logger.level == logging.DEBUG
 
     reset_logger("foo")
@@ -61,13 +60,13 @@ def test_setup_logging_w_incorrect_scope():
 
     base_logger = logging.getLogger("foo")
     assert base_logger.handlers == []
-    assert base_logger.propagate == False
+    assert not base_logger.propagate
     assert base_logger.level == logging.NOTSET
 
     # TODO(https://github.com/googleapis/python-api-core/issues/759): update test once we add logic to ignore an incorrect scope.
     logger = logging.getLogger("abc")
     assert isinstance(logger.handlers[0], logging.StreamHandler)
-    assert logger.propagate == False
+    assert not logger.propagate
     assert logger.level == logging.DEBUG
 
     reset_logger("foo")
@@ -82,12 +81,12 @@ def test_initialize_logging():
 
     base_logger = logging.getLogger("foo")
     assert base_logger.handlers == []
-    assert base_logger.propagate == False
+    assert not base_logger.propagate
     assert base_logger.level == logging.NOTSET
 
     module_logger = logging.getLogger("foo.bar")
     assert isinstance(module_logger.handlers[0], logging.StreamHandler)
-    assert module_logger.propagate == False
+    assert not module_logger.propagate
     assert module_logger.level == logging.DEBUG
 
     base_logger.propagate = True
@@ -96,10 +95,9 @@ def test_initialize_logging():
     with mock.patch("os.getenv", return_value="foo.bar"):
         with mock.patch("google.api_core.client_logging._BASE_LOGGER_NAME", "foo"):
             initialize_logging()
-    
-    assert base_logger.propagate == True
-    assert module_logger.propagate == True
 
+    assert base_logger.propagate
+    assert module_logger.propagate
 
     reset_logger("foo")
     reset_logger("foo.bar")