Skip to content

Commit c2e9596

Browse files
committed
added assertions to tests
1 parent d14a0c6 commit c2e9596

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

tests/unit/test_bidi.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,9 @@ def test_close(self):
296296
# ensure the request queue was signaled to stop.
297297
assert bidi_rpc.pending_requests == 1
298298
assert bidi_rpc._request_queue.get() is None
299+
# ensure request and callbacks are cleaned up
300+
assert bidi_rpc._initial_request is None
301+
assert not bidi_rpc._callbacks
299302

300303
def test_close_no_rpc(self):
301304
bidi_rpc = bidi.BidiRpc(None)
@@ -623,6 +626,8 @@ def cancel_side_effect():
623626
assert bidi_rpc.pending_requests == 1
624627
assert bidi_rpc._request_queue.get() is None
625628
assert bidi_rpc._finalized
629+
assert bidi_rpc._initial_request is None
630+
assert not bidi_rpc._callbacks
626631

627632
def test_reopen_failure_on_rpc_restart(self):
628633
error1 = ValueError("1")
@@ -777,6 +782,7 @@ def on_response(response):
777782
consumer.stop()
778783

779784
assert consumer.is_active is False
785+
assert consumer._on_response is None
780786

781787
def test_wake_on_error(self):
782788
should_continue = threading.Event()
@@ -884,6 +890,7 @@ def close_side_effect():
884890

885891
consumer.stop()
886892
assert consumer.is_active is False
893+
assert consumer._on_response is None
887894

888895
# calling stop twice should not result in an error.
889896
consumer.stop()

0 commit comments

Comments
 (0)