Skip to content

Commit 1054405

Browse files
authored
refactor: resolve identifier package names in nodes.py (#1385)
* fix: resolve identifier package names in nodes.py * fix format * revert table.num_rows change
1 parent 641abea commit 1054405

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

bigframes/core/nodes.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,7 @@ class ReadLocalNode(LeafNode):
800800
# Mapping of local ids to bfet id.
801801
scan_list: ScanList
802802
# Offsets are generated only if this is non-null
803-
offsets_col: Optional[bigframes.core.identifiers.ColumnId] = None
803+
offsets_col: Optional[identifiers.ColumnId] = None
804804
session: typing.Optional[bigframes.session.Session] = None
805805

806806
@property
@@ -1039,7 +1039,7 @@ class CachedTableNode(ReadTableNode):
10391039
# Unary nodes
10401040
@dataclasses.dataclass(frozen=True, eq=False)
10411041
class PromoteOffsetsNode(UnaryNode, AdditiveNode):
1042-
col_id: bigframes.core.identifiers.ColumnId
1042+
col_id: identifiers.ColumnId
10431043

10441044
@property
10451045
def non_local(self) -> bool:
@@ -1317,9 +1317,7 @@ def remap_refs(
13171317
class ProjectionNode(UnaryNode, AdditiveNode):
13181318
"""Assigns new variables (without modifying existing ones)"""
13191319

1320-
assignments: typing.Tuple[
1321-
typing.Tuple[ex.Expression, bigframes.core.identifiers.ColumnId], ...
1322-
]
1320+
assignments: typing.Tuple[typing.Tuple[ex.Expression, identifiers.ColumnId], ...]
13231321

13241322
def _validate(self):
13251323
input_types = self.child._dtype_lookup
@@ -1445,9 +1443,7 @@ def remap_refs(
14451443

14461444
@dataclasses.dataclass(frozen=True, eq=False)
14471445
class AggregateNode(UnaryNode):
1448-
aggregations: typing.Tuple[
1449-
typing.Tuple[ex.Aggregation, bigframes.core.identifiers.ColumnId], ...
1450-
]
1446+
aggregations: typing.Tuple[typing.Tuple[ex.Aggregation, identifiers.ColumnId], ...]
14511447
by_column_ids: typing.Tuple[ex.DerefOp, ...] = tuple([])
14521448
order_by: Tuple[OrderingExpression, ...] = ()
14531449
dropna: bool = True
@@ -1539,7 +1535,7 @@ def remap_refs(
15391535
class WindowOpNode(UnaryNode, AdditiveNode):
15401536
expression: ex.Aggregation
15411537
window_spec: window.WindowSpec
1542-
output_name: bigframes.core.identifiers.ColumnId
1538+
output_name: identifiers.ColumnId
15431539
never_skip_nulls: bool = False
15441540
skip_reproject_unsafe: bool = False
15451541

@@ -1682,7 +1678,7 @@ def remap_refs(
16821678
class ExplodeNode(UnaryNode):
16831679
column_ids: typing.Tuple[ex.DerefOp, ...]
16841680
# Offsets are generated only if this is non-null
1685-
offsets_col: Optional[bigframes.core.identifiers.ColumnId] = None
1681+
offsets_col: Optional[identifiers.ColumnId] = None
16861682

16871683
@property
16881684
def row_preserving(self) -> bool:

0 commit comments

Comments
 (0)