Skip to content

Commit 49c1a92

Browse files
authored
chore: cleanup type errors in bigframes/core/indexers.py (#779)
1 parent 6a57a26 commit 49c1a92

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

bigframes/core/indexers.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,8 @@ def __getitem__(self, key):
159159
)
160160

161161
columns = key[1]
162-
if isinstance(columns, pd.Series) and columns.dtype == "bool":
163-
# TODO(b/340892590): fix type error
164-
columns = df.columns[columns] # type: ignore
162+
if isinstance(columns, pd.Series) and columns.dtype == bool:
163+
columns = df.columns[typing.cast(pd.Series, columns)]
165164

166165
return df[columns]
167166

@@ -252,7 +251,7 @@ def __getitem__(self, key: tuple) -> bigframes.core.scalar.Scalar:
252251
raise ValueError(error_message)
253252
if len(key) != 2:
254253
raise TypeError(error_message)
255-
block: bigframes.core.blocks.Block = self._dataframe._block # type: ignore
254+
block: bigframes.core.blocks.Block = self._dataframe._block
256255
column_block = block.select_columns([block.value_columns[key[1]]])
257256
column = bigframes.series.Series(column_block)
258257
return column.iloc[key[0]]
@@ -376,14 +375,14 @@ def _perform_loc_list_join(
376375
)
377376
result = result.rename(original_name)
378377
else:
379-
result = series_or_dataframe._perform_join_by_index(keys_index, how="right") # type: ignore
378+
result = series_or_dataframe._perform_join_by_index(keys_index, how="right")
380379

381380
if drop_levels and series_or_dataframe.index.nlevels > keys_index.nlevels:
382381
# drop common levels
383382
levels_to_drop = [
384383
name for name in series_or_dataframe.index.names if name in keys_index.names
385384
]
386-
result = result.droplevel(levels_to_drop) # type: ignore
385+
result = result.droplevel(levels_to_drop)
387386
return result
388387

389388

0 commit comments

Comments
 (0)