Skip to content

Commit 6dff860

Browse files
authored
chore: update owlbot script to prevent silent failures at s.replace (#889)
* chore: update owlbot script to prevent silent failures at s.replace * fix errors * removing s.replace for CONTRIBUTING.rst because it was excluded from templated files
1 parent 991bb0a commit 6dff860

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

owlbot.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
# ----------------------------------------------------------------------------
6262

6363
# Encourage sharring all relevant versions in bug reports.
64-
s.replace(
64+
assert 1 == s.replace(
6565
[".github/ISSUE_TEMPLATE/bug_report.md"],
6666
re.escape("#### Steps to reproduce\n"),
6767
textwrap.dedent(
@@ -90,23 +90,23 @@
9090
)
9191

9292
# Make sure build includes all necessary files.
93-
s.replace(
93+
assert 1 == s.replace(
9494
["MANIFEST.in"],
9595
re.escape("recursive-include google"),
9696
"recursive-include third_party/bigframes_vendored *\nrecursive-include bigframes",
9797
)
9898

9999
# Even though BigQuery DataFrames isn't technically a client library, we are
100100
# opting into Cloud RAD for docs hosting.
101-
s.replace(
101+
assert 1 == s.replace(
102102
[".kokoro/docs/common.cfg"],
103103
re.escape('value: "docs-staging-v2-staging"'),
104104
'value: "docs-staging-v2"',
105105
)
106106

107107
# Use a custom table of contents since the default one isn't organized well
108108
# enough for the number of classes we have.
109-
s.replace(
109+
assert 1 == s.replace(
110110
[".kokoro/publish-docs.sh"],
111111
(
112112
re.escape("# upload docs")
@@ -124,19 +124,12 @@
124124
)
125125

126126
# Fixup the documentation.
127-
s.replace(
127+
assert 1 == s.replace(
128128
["docs/conf.py"],
129129
re.escape("Google Cloud Client Libraries for bigframes"),
130130
"BigQuery DataFrames provides DataFrame APIs on the BigQuery engine",
131131
)
132132

133-
# Update the contributing guide to reflect some differences in this repo.
134-
s.replace(
135-
["CONTRIBUTING.rst"],
136-
re.escape("blacken"),
137-
"format",
138-
)
139-
140133
# ----------------------------------------------------------------------------
141134
# Samples templates
142135
# ----------------------------------------------------------------------------

0 commit comments

Comments
 (0)