chore: clarify that hasattr is needed due to __init__ not running yet

Author: tswast

bigframes/core/log_adapter.py

@@ -302,26 +302,34 @@ def _get_bq_client(*args, **kwargs):
     return None
 
 
+def _is_session_initialized(session):
+    """Return True if fully initialized.
+
+    Because the method logger could get called before Session.__init__ has a
+    chance to run, we use the globals in that case.
+    """
+    return hasattr(session, "_api_methods_lock") and hasattr(session, "_api_methods")
+
+
 def _find_session(*args, **kwargs):
     # This function cannot import Session at the top level because Session
     # imports log_adapter.
-    # We can't import bigframes.session in type checking block either.
     from bigframes.session import Session
 
-    if args and isinstance(args[0], Session):
-        # In unit tests, we might be working with a mock Session object that
-        # passes isinstance but doesn't have the instance attributes set in
-        # __init__.
-        session = args[0]
-        if hasattr(session, "_api_methods_lock") and hasattr(session, "_api_methods"):
-            return session
+    session = args[0] if args else None
+    if (
+        session is not None
+        and isinstance(session, Session)
+        and _is_session_initialized(session)
+    ):
+        return session
 
     session = kwargs.get("session")
-    if session is not None and isinstance(session, Session):
-        # In unit tests, we might be working with a mock Session object that
-        # passes isinstance but doesn't have the instance attributes set in
-        # __init__.
-        if hasattr(session, "_api_methods_lock") and hasattr(session, "_api_methods"):
-            return session
+    if (
+        session is not None
+        and isinstance(session, Session)
+        and _is_session_initialized(session)
+    ):
+        return session
 
     return None