Skip to content

Commit 86ed01b

Browse files
authored
Refactor: Simplify fillna_op implementation (#2261)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
1 parent 8f490e6 commit 86ed01b

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

bigframes/core/compile/ibis_compiler/scalar_op_registry.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1722,10 +1722,7 @@ def fillna_op(
17221722
x: ibis_types.Value,
17231723
y: ibis_types.Value,
17241724
):
1725-
if hasattr(x, "fill_null"):
1726-
return x.fill_null(typing.cast(ibis_types.Scalar, y))
1727-
else:
1728-
return x.fill_null(typing.cast(ibis_types.Scalar, y))
1725+
return x.fill_null(typing.cast(ibis_types.Scalar, y))
17291726

17301727

17311728
@scalar_op_compiler.register_binary_op(ops.round_op)

0 commit comments

Comments
 (0)