Skip to content

Commit a7cbf39

Browse files
authored
chore: test with latest sqlglot in prerelease tests (#1283)
* chore: test with latest sqlglot in prerelease tests * Update noxfile.py * Update noxfile.py * add vendored ibis dependencies to constraints * update minimum typing-extensions
1 parent 5a2731b commit a7cbf39

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

noxfile.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -589,20 +589,16 @@ def prerelease(session: nox.sessions.Session, tests_path, extra_pytest_options=(
589589
)
590590
already_installed.add("pandas")
591591

592-
# Ibis has introduced breaking changes. Let's exclude ibis head
593-
# from prerelease install list for now. We should enable the head back
594-
# once bigframes supports the version at HEAD.
595-
# session.install(
596-
# "--upgrade",
597-
# "-e", # Use -e so that py.typed file is included.
598-
# "git+https://github.com/ibis-project/ibis.git#egg=ibis-framework",
599-
# )
592+
# Try to avoid a cap on our SQLGlot so that bigframes
593+
# can be integrated with SQLMesh. See:
594+
# https://github.com/googleapis/python-bigquery-dataframes/issues/942
595+
# If SQLGlot introduces something that breaks us, lets file an issue
596+
# upstream and/or make sure we fix bigframes to work with it.
600597
session.install(
601598
"--upgrade",
602-
"--pre",
603-
"ibis-framework>=9.0.0,<=9.2.0",
599+
"git+https://github.com/tobymao/sqlglot.git#egg=sqlglot",
604600
)
605-
already_installed.add("ibis-framework")
601+
already_installed.add("sqlglot")
606602

607603
# Workaround https://github.com/googleapis/python-db-dtypes-pandas/issues/178
608604
session.install("--no-deps", "db-dtypes")

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"python-dateutil>=2.8.2,<3",
6969
"pytz>=2022.7",
7070
"toolz>=0.11,<2",
71-
"typing-extensions>=4.3.0,<5",
71+
"typing-extensions>=4.5.0,<5",
7272
"rich>=12.4.4,<14",
7373
]
7474
extras = {

testing/constraints-3.9.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,11 @@ tabulate==0.9
2626
ipywidgets==7.7.1
2727
humanize==4.6.0
2828
matplotlib==3.7.1
29+
# For vendored ibis-framework.
30+
atpublic==2.3
31+
parsy==2.0
32+
python-dateutil==2.8.2
33+
pytz==2022.7
34+
toolz==0.11
35+
typing-extensions==4.5.0
36+
rich==12.4.4

0 commit comments

Comments
 (0)