Skip to content

Commit afc1242

Browse files
authored
refactor: Rename internal functions used externally in _utils.py (#1959)
1 parent fed8039 commit afc1242

File tree

7 files changed

+16
-16
lines changed

7 files changed

+16
-16
lines changed

bigframes/functions/_function_client.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ def provision_bq_managed_function(
245245

246246
# Augment user package requirements with any internal package
247247
# requirements.
248-
packages = _utils._get_updated_package_requirements(
248+
packages = _utils.get_updated_package_requirements(
249249
packages, is_row_processor, capture_references, ignore_package_version=True
250250
)
251251
if packages:
@@ -258,7 +258,7 @@ def provision_bq_managed_function(
258258
bq_function_name = name
259259
if not bq_function_name:
260260
# Compute a unique hash representing the user code.
261-
function_hash = _utils._get_hash(func, packages)
261+
function_hash = _utils.get_hash(func, packages)
262262
bq_function_name = _utils.get_bigframes_function_name(
263263
function_hash,
264264
session_id,
@@ -539,12 +539,12 @@ def provision_bq_remote_function(
539539
"""Provision a BigQuery remote function."""
540540
# Augment user package requirements with any internal package
541541
# requirements
542-
package_requirements = _utils._get_updated_package_requirements(
542+
package_requirements = _utils.get_updated_package_requirements(
543543
package_requirements, is_row_processor
544544
)
545545

546546
# Compute a unique hash representing the user code
547-
function_hash = _utils._get_hash(def_, package_requirements)
547+
function_hash = _utils.get_hash(def_, package_requirements)
548548

549549
# If reuse of any existing function with the same name (indicated by the
550550
# same hash of its source code) is not intended, then attach a unique

bigframes/functions/_function_session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ def wrapper(func):
597597
bqrf_metadata = _utils.get_bigframes_metadata(
598598
python_output_type=py_sig.return_annotation
599599
)
600-
post_process_routine = _utils._build_unnest_post_routine(
600+
post_process_routine = _utils.build_unnest_post_routine(
601601
py_sig.return_annotation
602602
)
603603
py_sig = py_sig.replace(return_annotation=str)

bigframes/functions/_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def get_remote_function_locations(bq_location):
6363
return bq_location, cloud_function_region
6464

6565

66-
def _get_updated_package_requirements(
66+
def get_updated_package_requirements(
6767
package_requirements=None,
6868
is_row_processor=False,
6969
capture_references=True,
@@ -105,7 +105,7 @@ def _get_updated_package_requirements(
105105
return requirements
106106

107107

108-
def _clean_up_by_session_id(
108+
def clean_up_by_session_id(
109109
bqclient: bigquery.Client,
110110
gcfclient: functions_v2.FunctionServiceClient,
111111
dataset: bigquery.DatasetReference,
@@ -169,7 +169,7 @@ def _clean_up_by_session_id(
169169
pass
170170

171171

172-
def _get_hash(def_, package_requirements=None):
172+
def get_hash(def_, package_requirements=None):
173173
"Get hash (32 digits alphanumeric) of a function."
174174
# There is a known cell-id sensitivity of the cloudpickle serialization in
175175
# notebooks https://github.com/cloudpipe/cloudpickle/issues/538. Because of
@@ -279,7 +279,7 @@ def get_python_version(is_compat: bool = False) -> str:
279279
return f"python{major}{minor}" if is_compat else f"python-{major}.{minor}"
280280

281281

282-
def _build_unnest_post_routine(py_list_type: type[list]):
282+
def build_unnest_post_routine(py_list_type: type[list]):
283283
sdk_type = function_typing.sdk_array_output_type_from_python_type(py_list_type)
284284
assert sdk_type.array_element_type is not None
285285
inner_sdk_type = sdk_type.array_element_type

bigframes/functions/function.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def _try_import_routine(
9090
return BigqueryCallableRoutine(
9191
udf_def,
9292
session,
93-
post_routine=_utils._build_unnest_post_routine(override_type),
93+
post_routine=_utils.build_unnest_post_routine(override_type),
9494
)
9595
return BigqueryCallableRoutine(udf_def, session, is_managed=not is_remote)
9696

@@ -107,7 +107,7 @@ def _try_import_row_routine(
107107
return BigqueryCallableRowRoutine(
108108
udf_def,
109109
session,
110-
post_routine=_utils._build_unnest_post_routine(override_type),
110+
post_routine=_utils.build_unnest_post_routine(override_type),
111111
)
112112
return BigqueryCallableRowRoutine(udf_def, session, is_managed=not is_remote)
113113

bigframes/pandas/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ def clean_up_by_session_id(
293293
session.bqclient, dataset, session_id
294294
)
295295

296-
bff_utils._clean_up_by_session_id(
296+
bff_utils.clean_up_by_session_id(
297297
session.bqclient, session.cloudfunctionsclient, dataset, session_id
298298
)
299299

bigframes/testing/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,11 +440,11 @@ def get_function_name(func, package_requirements=None, is_row_processor=False):
440440
"""Get a bigframes function name for testing given a udf."""
441441
# Augment user package requirements with any internal package
442442
# requirements.
443-
package_requirements = bff_utils._get_updated_package_requirements(
443+
package_requirements = bff_utils.get_updated_package_requirements(
444444
package_requirements, is_row_processor
445445
)
446446

447447
# Compute a unique hash representing the user code.
448-
function_hash = bff_utils._get_hash(func, package_requirements)
448+
function_hash = bff_utils.get_hash(func, package_requirements)
449449

450450
return f"bigframes_{function_hash}"

tests/system/large/functions/test_remote_function.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -527,8 +527,8 @@ def add_one(x):
527527
add_one_uniq, add_one_uniq_dir = make_uniq_udf(add_one)
528528

529529
# Expected cloud function name for the unique udf
530-
package_requirements = bff_utils._get_updated_package_requirements()
531-
add_one_uniq_hash = bff_utils._get_hash(add_one_uniq, package_requirements)
530+
package_requirements = bff_utils.get_updated_package_requirements()
531+
add_one_uniq_hash = bff_utils.get_hash(add_one_uniq, package_requirements)
532532
add_one_uniq_cf_name = bff_utils.get_cloud_function_name(
533533
add_one_uniq_hash, session.session_id
534534
)

0 commit comments

Comments
 (0)