Skip to content

Commit ca284cc

Browse files
authored
chore: clean up type errors in test_api_primitives (#696)
1 parent 9386373 commit ca284cc

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/unit/ml/test_api_primitives.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ def test_base_estimator_repr():
3131
assert estimator.__repr__() == "LinearRegression()"
3232

3333
# TODO(b/340891292): fix type error
34-
estimator = bigframes.ml.decomposition.PCA(n_components=7) # type: ignore
35-
assert estimator.__repr__() == "PCA(n_components=7)"
34+
pca_estimator = bigframes.ml.decomposition.PCA(n_components=7)
35+
assert pca_estimator.__repr__() == "PCA(n_components=7)"
3636

3737

3838
@pytest.mark.skipif(sklearn_linear_model is None, reason="requires sklearn")
@@ -50,6 +50,6 @@ def test_base_estimator_repr_matches_sklearn():
5050
assert estimator.__repr__() == sklearn_estimator.__repr__()
5151

5252
# TODO(b/340891292): fix type error
53-
estimator = bigframes.ml.decomposition.PCA(n_components=7) # type: ignore
53+
pca_estimator = bigframes.ml.decomposition.PCA(n_components=7)
5454
sklearn_estimator = sklearn_decomposition.PCA(n_components=7)
55-
assert estimator.__repr__() == sklearn_estimator.__repr__()
55+
assert pca_estimator.__repr__() == sklearn_estimator.__repr__()

0 commit comments

Comments
 (0)