Skip to content

Commit eff964b

Browse files
authored
refactor: rename rewrite.operators file to rewrite.timedeltas (#1382)
1 parent ffe7dc6 commit eff964b

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

bigframes/core/compile/compiler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def compile_sql(
5858
# TODO: get rid of output_ids arg
5959
assert len(output_ids) == len(list(node.fields))
6060
node = set_output_names(node, output_ids)
61-
node = nodes.top_down(node, rewrites.rewrite_timedelta_ops)
61+
node = nodes.top_down(node, rewrites.rewrite_timedelta_expressions)
6262
if ordered:
6363
node, limit = rewrites.pullup_limit_from_slice(node)
6464
node = nodes.bottom_up(node, rewrites.rewrite_slice)
@@ -85,7 +85,7 @@ def compile_sql(
8585
def compile_peek_sql(self, node: nodes.BigFrameNode, n_rows: int) -> str:
8686
ids = [id.sql for id in node.ids]
8787
node = nodes.bottom_up(node, rewrites.rewrite_slice)
88-
node = nodes.top_down(node, rewrites.rewrite_timedelta_ops)
88+
node = nodes.top_down(node, rewrites.rewrite_timedelta_expressions)
8989
node, _ = rewrites.pull_up_order(
9090
node, order_root=False, ordered_joins=self.strict
9191
)
@@ -99,7 +99,7 @@ def compile_raw(
9999
str, typing.Sequence[google.cloud.bigquery.SchemaField], bf_ordering.RowOrdering
100100
]:
101101
node = nodes.bottom_up(node, rewrites.rewrite_slice)
102-
node = nodes.top_down(node, rewrites.rewrite_timedelta_ops)
102+
node = nodes.top_down(node, rewrites.rewrite_timedelta_expressions)
103103
node, ordering = rewrites.pull_up_order(node, ordered_joins=self.strict)
104104
node = rewrites.column_pruning(node)
105105
ir = self.compile_node(node)
@@ -108,7 +108,7 @@ def compile_raw(
108108

109109
def _preprocess(self, node: nodes.BigFrameNode):
110110
node = nodes.bottom_up(node, rewrites.rewrite_slice)
111-
node = nodes.top_down(node, rewrites.rewrite_timedelta_ops)
111+
node = nodes.top_down(node, rewrites.rewrite_timedelta_expressions)
112112
node, _ = rewrites.pull_up_order(
113113
node, order_root=False, ordered_joins=self.strict
114114
)

bigframes/core/rewrite/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@
1515
from bigframes.core.rewrite.identifiers import remap_variables
1616
from bigframes.core.rewrite.implicit_align import try_row_join
1717
from bigframes.core.rewrite.legacy_align import legacy_join_as_projection
18-
from bigframes.core.rewrite.operators import rewrite_timedelta_ops
1918
from bigframes.core.rewrite.order import pull_up_order
2019
from bigframes.core.rewrite.pruning import column_pruning
2120
from bigframes.core.rewrite.slices import pullup_limit_from_slice, rewrite_slice
21+
from bigframes.core.rewrite.timedeltas import rewrite_timedelta_expressions
2222

2323
__all__ = [
2424
"legacy_join_as_projection",
2525
"try_row_join",
2626
"rewrite_slice",
27-
"rewrite_timedelta_ops",
27+
"rewrite_timedelta_expressions",
2828
"pullup_limit_from_slice",
2929
"remap_variables",
3030
"pull_up_order",

bigframes/core/rewrite/operators.py renamed to bigframes/core/rewrite/timedeltas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class _TypedExpr:
2828
dtype: dtypes.Dtype
2929

3030

31-
def rewrite_timedelta_ops(root: nodes.BigFrameNode) -> nodes.BigFrameNode:
31+
def rewrite_timedelta_expressions(root: nodes.BigFrameNode) -> nodes.BigFrameNode:
3232
"""
3333
Rewrites expressions to properly handle timedelta values, because this type does not exist
3434
in the SQL world.

0 commit comments

Comments
 (0)