Skip to content

Commit fbc31ab

Browse files
authored
test: fix prerelease tests (#239)
The heads of google-cloud-bigquery and google-cloud-bigquery-storage packages are installed with -e. This is leading to `from google.cloud import bigquery` looking into the folder of the latter and running into "ImportError: cannot import name 'bigquery' from 'google.cloud' (.../google-cloud-bigquery-storage/google/cloud/__init__.py). Removing -e from google-cloud-bigquery installation gets rid of this error. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes internal issue 313701211 🦕
1 parent f8917ab commit fbc31ab

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

noxfile.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,6 @@ def prerelease(session: nox.sessions.Session, tests_path):
548548
# Ensure we catch breaking changes in the client libraries early.
549549
session.install(
550550
"--upgrade",
551-
"-e",
552551
"git+https://github.com/googleapis/python-bigquery.git#egg=google-cloud-bigquery",
553552
)
554553
already_installed.add("google-cloud-bigquery")

0 commit comments

Comments
 (0)