Skip to content

Commit ff03a4a

Browse files
committed
clean up
1 parent f42ff08 commit ff03a4a

File tree

1 file changed

+2
-22
lines changed

1 file changed

+2
-22
lines changed

noxfile.py

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,6 @@
3333
ISORT_VERSION = "isort==5.12.0"
3434
MYPY_VERSION = "mypy==1.15.0"
3535

36-
# TODO: switch to 3.14 once remote functions adds a runtime for it
37-
# https://cloud.google.com/run/docs/runtimes/python
38-
# https://cloud.google.com/functions/docs/runtime-support#python
39-
LATEST_FULLY_SUPPORTED_PYTHON = "3.13"
40-
4136
# Notebook tests should match colab and BQ Studio.
4237
# Check with import sys; sys.version_info
4338
# on a fresh notebook runtime.
@@ -135,7 +130,7 @@
135130
# from GitHub actions.
136131
"unit_noextras",
137132
"system-3.9", # No extras.
138-
f"system-{LATEST_FULLY_SUPPORTED_PYTHON}", # All extras.
133+
f"system-{DEFAULT_PYTHON_VERSION}", # All extras.
139134
"cover",
140135
# TODO(b/401609005): remove
141136
"cleanup",
@@ -419,7 +414,7 @@ def system(session: nox.sessions.Session):
419414
)
420415

421416

422-
@nox.session(python=LATEST_FULLY_SUPPORTED_PYTHON)
417+
@nox.session(python=DEFAULT_PYTHON_VERSION)
423418
def system_noextras(session: nox.sessions.Session):
424419
"""Run the system test suite."""
425420
run_system(
@@ -812,21 +807,6 @@ def notebook(session: nox.Session):
812807
"notebooks/dataframes/anywidget_mode.ipynb",
813808
]
814809

815-
# TODO: remove exception for Python 3.14 once remote functions adds a runtime for it
816-
# https://cloud.google.com/run/docs/runtimes/python
817-
# https://cloud.google.com/functions/docs/runtime-support#python
818-
# sys.exit(0) or pytest.skip(...).
819-
# See: https://github.com/treebeardtech/nbmake/issues/134
820-
if session.python == "3.14":
821-
denylist.extend(
822-
[
823-
"notebooks/getting_started/getting_started_bq_dataframes.ipynb",
824-
"notebooks/remote_functions/remote_function_usecases.ipynb",
825-
"notebooks/remote_functions/remote_function_vertex_claude_model.ipynb",
826-
"notebooks/remote_functions/remote_function.ipynb",
827-
]
828-
)
829-
830810
# Convert each Path notebook object to a string using a list comprehension,
831811
# and remove tests that we choose not to test.
832812
notebooks = [str(nb) for nb in notebooks_list]

0 commit comments

Comments
 (0)