feat: remove illegal character check (#892)

* feat: remove illegal character check

* more testing

* more testing redux

* more testing redux II

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Delete compliance_comparison_script.py

inadvertently uploaded.

* Delete issue_test.py

inadvertently uploaded.

* Delete noxfile.py.bak

inadvertently uploaded.

* Delete to_delete.py

inadvertently uploaded.

* Update sqlalchemy_bigquery/base.py

* Update sqlalchemy_bigquery/base.py

* Update sqlalchemy_bigquery/base.py

* Update sqlalchemy_bigquery/base.py

* Update sqlalchemy_bigquery/base.py

* Update sqlalchemy_bigquery/base.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update sqlalchemy_bigquery/base.py

* Update sqlalchemy_bigquery/base.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update sqlalchemy_bigquery/base.py

Co-authored-by: Tim Swast <[email protected]>

* Update sqlalchemy_bigquery/base.py

* updates illegal character check, removing backtick

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Swast <[email protected]>

Author: 3 people

sqlalchemy_bigquery/base.py

@@ -56,7 +56,10 @@
 from .parse_url import parse_url
 from . import _helpers, _struct, _types
 
-FIELD_ILLEGAL_CHARACTERS = re.compile(r"[^\w]+")
+# Illegal characters is intended to be all characters that are not explicitly
+# allowed as part of the flexible column names.
+# https://cloud.google.com/bigquery/docs/schemas#flexible-column-names
+FIELD_ILLEGAL_CHARACTERS = re.compile(r'[!"$()*,./;?@[\\\]^{}~\n]+', re.ASCII)
 
 TABLE_VALUED_ALIAS_ALIASES = "bigquery_table_valued_alias_aliases"
 

tests/system/test_sqlalchemy_bigquery.py

@@ -432,7 +432,7 @@ def test_labels(session, table, session_using_test_dataset, table_using_test_dat
             # Valid
             table.c.string.label("_123abc"),
             # Invalid, contains illegal characters
-            table.c.string.label("!@#$%^&*()~`"),
+            table.c.string.label("!@$^*()\n{};/,.~abc"),
         )
         result = result.all()
         assert len(result) > 0