Skip to content

Commit 04cb59e

Browse files
committed
updates docstring and removes comment
1 parent c267a3c commit 04cb59e

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

google/cloud/bigquery/external_config.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -475,8 +475,6 @@ def skip_leading_rows(self):
475475
def skip_leading_rows(self, value):
476476
self._properties["skipLeadingRows"] = str(value)
477477

478-
# TODO: null_marker needs to be added to this code base.
479-
480478
@property
481479
def null_markers(self) -> Optional[List[str]]:
482480
"""Optional[List[str]]: A list of strings represented as SQL NULL value in a CSV file.
@@ -501,18 +499,18 @@ def null_markers(self, value: Optional[List[str]]):
501499

502500
@property
503501
def source_column_match(self) -> Optional[SourceColumnMatch]:
504-
"""Optional[SourceColumnMatch]: Controls the strategy used to match loaded
505-
columns to the schema. If not set, a sensible default is chosen based on
506-
how the schema is provided. If autodetect is used, then columns are matched
507-
by name. Otherwise, columns are matched by position. This is done to keep
508-
the behavior backward-compatible.
502+
"""Optional[google.cloud.bigquery.enums.SourceColumnMatch]: Controls the
503+
strategy used to match loaded columns to the schema. If not set, a sensible
504+
default is chosen based on how the schema is provided. If autodetect is
505+
used, then columns are matched by name. Otherwise, columns are matched by
506+
position. This is done to keep the behavior backward-compatible.
509507
510508
Acceptable values are:
511509
SOURCE_COLUMN_MATCH_UNSPECIFIED - Unspecified column name match option.
512510
POSITION - matches by position. This assumes that the columns are ordered
513511
the same way as the schema.
514512
NAME - matches by name. This reads the header row as column names and
515-
reorders columns to match the field names in the schema.
513+
reorders columns to match the field names in the schema.
516514
517515
See
518516
https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#ExternalDataConfiguration.FIELDS.source_column_match

0 commit comments

Comments
 (0)