Skip to content

Commit 5cece20

Browse files
committed
fix: updates tests on getters to resolve coverage issues
1 parent 48c8cc6 commit 5cece20

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

tests/unit/test_external_config.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -930,10 +930,12 @@ def test_ctor_initialization(
930930
parameters=parameters,
931931
)
932932

933-
assert instance._properties == {
934-
"defaultStorageLocationUri": default_storage_location_uri,
935-
"parameters": parameters,
936-
}
933+
# assert instance._properties == {
934+
# "defaultStorageLocationUri": default_storage_location_uri,
935+
# "parameters": parameters,
936+
# }
937+
assert instance.default_storage_location_uri == default_storage_location_uri
938+
assert instance.parameters == parameters
937939

938940
def test_ctor_invalid_input(self):
939941
"""Test ExternalCatalogDatasetOptions constructor with invalid input."""
@@ -1024,16 +1026,16 @@ def test_ctor_initialization(
10241026
parameters=parameters,
10251027
storage_descriptor=storage_descriptor,
10261028
)
1027-
1028-
assert instance._properties["connectionId"] == connection_id
1029-
assert instance._properties["parameters"] == parameters
1029+
1030+
assert instance.connection_id == connection_id
1031+
assert instance.parameters == parameters
10301032
if storage_descriptor is not None:
10311033
assert (
1032-
instance._properties["storageDescriptor"]
1034+
instance.storage_descriptor.to_api_repr()
10331035
== storage_descriptor.to_api_repr()
10341036
)
10351037
else:
1036-
assert instance._properties["storageDescriptor"] == storage_descriptor
1038+
assert instance.storage_descriptor == None
10371039

10381040
@pytest.mark.parametrize(
10391041
"connection_id, parameters, storage_descriptor",

0 commit comments

Comments
 (0)