remove trailing whitespace and add test assertions

Author: drokeye

google/cloud/bigquery/dataset.py

@@ -507,7 +507,6 @@ def entity_id(self) -> Optional[Union[Dict[str, Any], str]]:
     def __eq__(self, other):
         if not isinstance(other, AccessEntry):
             return NotImplemented
-
         return (
             self.role == other.role
             and self.entity_type == other.entity_type
@@ -571,7 +570,6 @@ def to_api_repr(self):
                 resource[k] = v
 
         return resource
-        
 
     @classmethod
     def from_api_repr(cls, resource: dict) -> "AccessEntry":
@@ -585,7 +583,6 @@ def from_api_repr(cls, resource: dict) -> "AccessEntry":
             google.cloud.bigquery.dataset.AccessEntry:
                 Access entry parsed from ``resource``.
         """
-        
         role = resource.get("role")
         condition = None
         if "condition" in resource:
@@ -595,7 +592,7 @@ def from_api_repr(cls, resource: dict) -> "AccessEntry":
         entity_id = None
 
         for key, value in resource.items():
-            if key in ("role", "condition"):
+            if key in ("role","condition"):
                 continue
             entity_type = key
             entity_id = value

tests/unit/test_dataset.py

@@ -1767,26 +1767,65 @@ def test__hash__with_minimal_inputs(self):
             description=None,
         )
         assert hash(cond1) is not None
-        
+
     def test_access_entry_view_equality(self):
-        
+
         from google.cloud import bigquery
-        
+
         entry1 = bigquery.dataset.AccessEntry(
             entity_type="view",
             entity_id={
-                "projectId": "my_project",
-                "datasetId": "my_dataset",
-                "tableId": "my_table",
+                "projectId":"my_project",
+                "datasetId":"my_dataset",
+                "tableId":"my_table",
             },
         )
         entry2 = bigquery.dataset.AccessEntry.from_api_repr({
-            "view": {
-                "projectId": "my_project",
-                "datasetId": "my_dataset",
-                "tableId": "my_table",
+            "view":{
+                "projectId":"my_project",
+                "datasetId":"my_dataset",
+                "tableId":"my_table",
             }
         })
 
-        assert entry1 == entry2
+        entry3 = bigquery.dataset.AccessEntry(
+            entity_type="routine",
+            entity_id={
+                "projectId":"my_project",
+                "datasetId":"my_dataset",
+                "routineId":"my_routine",
+            },
+        )
 
+        entry4 = bigquery.dataset.AccessEntry.from_api_repr({
+            "routine":{
+                "projectId":"my_project",
+                "datasetId":"my_dataset",
+                "routineId":"my_routine",
+            }
+        })
+
+        entry5 = bigquery.dataset.AccessEntry(
+            entity_type="dataset",
+            entity_id={
+                "dataset": {
+                    "projectId":"my_project",
+                    "datasetId":"my_dataset",
+                },
+                "target_types":"VIEWS",
+            },
+        )
+
+        entry6 = bigquery.dataset.AccessEntry.from_api_repr({
+            "dataset":{
+                "dataset":{
+                    "projectId":"my_project",
+                    "datasetId":"my_dataset",
+                },
+                "target_types":"VIEWS",
+            }
+        })
+
+        assert entry1 == entry2
+        assert entry3 == entry4
+        assert entry5 == entry6