updates type hints across the board

Author: chalmerlowe

google/cloud/bigquery/external_config.py

@@ -22,6 +22,7 @@
 
 import base64
 import copy
+import typing
 from typing import Any, Dict, FrozenSet, Iterable, Optional, Union
 
 from google.cloud.bigquery._helpers import _to_bytes
@@ -835,9 +836,9 @@ def schema(self):
         See
         https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#ExternalDataConfiguration.FIELDS.schema
         """
-        # TODO: The typehinting for this needs work. Setting this pragma to temporarily
-        # manage a pytype issue that came up in another PR. See Issue: #2132
-        prop: Dict[str, Any] = self._properties.get("schema", {})
+        prop: Dict[str, Any] = typing.cast(
+            Dict[str, Any], self._properties.get("schema", {})
+        )
         return [SchemaField.from_api_repr(field) for field in prop.get("fields", [])]
 
     @schema.setter

google/cloud/bigquery/job/base.py

@@ -435,8 +435,6 @@ def __init__(self, job_id, client):
     @property
     def configuration(self) -> _JobConfig:
         """Job-type specific configurtion."""
-        # TODO: The typehinting for this needs work. Setting this pragma to temporarily
-        # manage a pytype issue that came up in another PR. See Issue: #2132
         configuration: _JobConfig = self._CONFIG_CLASS()  # pytype: disable=not-callable
         configuration._properties = self._properties.setdefault("configuration", {})
         return configuration

google/cloud/bigquery/routine/routine.py

@@ -518,22 +518,16 @@ def __init__(self):
     @property
     def project(self):
         """str: ID of the project containing the routine."""
-        # TODO: The typehinting for this needs work. Setting this pragma to temporarily
-        # manage a pytype issue that came up in another PR. See Issue: #2132
         return self._properties.get("projectId", "")
 
     @property
     def dataset_id(self):
         """str: ID of dataset containing the routine."""
-        # TODO: The typehinting for this needs work. Setting this pragma to temporarily
-        # manage a pytype issue that came up in another PR. See Issue: #2132
         return self._properties.get("datasetId", "")
 
     @property
     def routine_id(self):
         """str: The routine ID."""
-        # TODO: The typehinting for this needs work. Setting this pragma to temporarily
-        # manage a pytype issue that came up in another PR. See Issue: #2132
         return self._properties.get("routineId", "")
 
     @property

google/cloud/bigquery/schema.py

@@ -232,9 +232,11 @@ def __init__(
         if max_length is not _DEFAULT_VALUE:
             self._properties["maxLength"] = max_length
         if policy_tags is not _DEFAULT_VALUE:
-            # TODO: The typehinting for this needs work. Setting this pragma to temporarily
-            # manage a pytype issue that came up in another PR. See Issue: #2132
-            self._properties["policyTags"] = policy_tags.to_api_repr() if policy_tags is not None else None
+            self._properties["policyTags"] = (
+                policy_tags.to_api_repr()
+                if isinstance(policy_tags, PolicyTagList)
+                else None
+            )
         if isinstance(range_element_type, str):
             self._properties["rangeElementType"] = {"type": range_element_type}
         if isinstance(range_element_type, FieldElementType):

google/cloud/bigquery/table.py

@@ -137,9 +137,9 @@ def _reference_getter(table):
     return TableReference(dataset_ref, table.table_id)
 
 
-# TODO: The typehinting for this needs work. Setting this pragma to temporarily
-# manage a pytype issue that came up in another PR. See Issue: #2132
-def _view_use_legacy_sql_getter(table: "Table") -> bool:
+def _view_use_legacy_sql_getter(
+    table: Union["Table", "TableListItem"]
+) -> Optional[bool]:
     """bool: Specifies whether to execute the view with Legacy or Standard SQL.
 
     This boolean specifies whether to execute the view with Legacy SQL
@@ -160,6 +160,7 @@ def _view_use_legacy_sql_getter(table: "Table") -> bool:
     if table.table_type == "VIEW":
         # The server-side default for useLegacySql is True.
         return True
+    return None  # explicit return statement to appease mypy
 
 
 class _TableBase: