fix: make AccessEntry equality consistent for view entity type

Author: drokeye

google/cloud/bigquery/dataset.py

@@ -506,7 +506,20 @@ def entity_id(self) -> Optional[Union[Dict[str, Any], str]]:
     def __eq__(self, other):
         if not isinstance(other, AccessEntry):
             return NotImplemented
-        return self._key() == other._key()
+
+        return (
+            self.role == other.role
+            and self.entity_type == other.entity_type
+            and self._normalize_entity_id(self.entity_id) == self._normalize_entity_id(other.entity_id)
+            and self.condition == other.condition
+        )
+
+    @staticmethod
+    def _normalize_entity_id(value):
+        """Ensure consistent equality for dicts like 'view'."""
+        if isinstance(value, dict):
+            return dict(sorted(value.items()))
+        return value
 
     def __ne__(self, other):
         return not self == other
@@ -542,8 +555,22 @@ def to_api_repr(self):
         Returns:
             Dict[str, object]: Access entry represented as an API resource
         """
-        resource = copy.deepcopy(self._properties)
+        resource = {}
+
+        if self.role is not None:
+            resource["role"] = self.role
+        if self.entity_type is not None:
+            resource[self.entity_type] = self.entity_id
+        if self.condition is not None:
+            resource["condition"] = self.condition.to_api_repr()
+
+        # Include any extra items preserved in _properties
+        for k, v in self._properties.items():
+            if k not in resource:
+                resource[k] = v
+
         return resource
+        
 
     @classmethod
     def from_api_repr(cls, resource: dict) -> "AccessEntry":
@@ -557,10 +584,33 @@ def from_api_repr(cls, resource: dict) -> "AccessEntry":
             google.cloud.bigquery.dataset.AccessEntry:
                 Access entry parsed from ``resource``.
         """
+        
+        role = resource.get("role")
+        condition = None
+        if "condition" in resource:
+            from google.cloud.bigquery.dataset import Condition
+            condition = Condition.from_api_repr(resource["condition"])
+
+        entity_type = None
+        entity_id = None
+
+        for key, value in resource.items():
+            if key in ("role", "condition"):
+                continue
+            entity_type = key
+            entity_id = value
+            break
+
+        entry = cls(
+            role=role,
+            entity_type=entity_type,
+            entity_id=entity_id,
+            condition=condition,
+        )
 
-        access_entry = cls()
-        access_entry._properties = resource.copy()
-        return access_entry
+        # Preserve additional _properties for roundtrip consistency:
+        entry._properties = dict(resource)
+        return entry
 
 
 class Dataset(object):

tests/unit/test_dataset.py

@@ -1767,3 +1767,26 @@ def test__hash__with_minimal_inputs(self):
             description=None,
         )
         assert hash(cond1) is not None
+        
+    def test_access_entry_view_equality(self):
+        
+        from google.cloud import bigquery
+        
+        entry1 = bigquery.dataset.AccessEntry(
+            entity_type="view",
+            entity_id={
+                "projectId": "my_project",
+                "datasetId": "my_dataset",
+                "tableId": "my_table",
+            },
+        )
+        entry2 = bigquery.dataset.AccessEntry.from_api_repr({
+            "view": {
+                "projectId": "my_project",
+                "datasetId": "my_dataset",
+                "tableId": "my_table",
+            }
+        })
+
+        assert entry1 == entry2
+