rename

Author: tswast

google/cloud/bigquery/_job_helpers.py

@@ -145,7 +145,7 @@ def do_query():
         try:
             query_job._begin(retry=retry, timeout=timeout)
             callback(
-                QueryRequestedEvent(
+                QuerySentEvent(
                     query=query,
                     billing_project=query_job.project,
                     location=query_job.location,
@@ -522,7 +522,7 @@ def do_query():
         span_attributes = {"path": path}
 
         callback(
-            QueryRequestedEvent(
+            QuerySentEvent(
                 query=query,
                 billing_project=project,
                 location=location,
@@ -666,7 +666,7 @@ def _wait_or_cancel(
 
 
 @dataclasses.dataclass(frozen=True)
-class QueryRequestedEvent:
+class QuerySentEvent:
     query: str
     billing_project: str
     location: Optional[str]

tests/unit/test_client_bigframes.py

@@ -22,6 +22,7 @@
 
 import google.auth.credentials
 import google.cloud.bigquery.client
+from google.cloud.bigquery import _job_helpers
 
 
 PROJECT = "test-project"
@@ -51,5 +52,12 @@ def test_query_and_wait_bigframes_callback(client):
             {"jobComplete": True}
         ),
     ]
-    callback = lambda _: None
+    callback = mock.Mock()
     client._query_and_wait_bigframes(query="SELECT 1", callback=callback)
+    callback.assert_has_calls(
+        mock.call(
+           _job_helpers.QuerySentEvent(
+               query="SELECT 1",
+            ),
+        )
+    )