Skip to content

Commit 9dad53d

Browse files
committed
Updates test of table property ECTO
1 parent 3d7a09f commit 9dad53d

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

tests/unit/test_table.py

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5880,6 +5880,7 @@ def test_external_catalog_table_options_getter(
58805880
dataset = DatasetReference(self.PROJECT, self.DS_ID)
58815881
table_ref = dataset.table(self.TABLE_NAME)
58825882
table = self._make_one(table_ref)
5883+
expected = external_catalog_table_options
58835884

58845885
# Confirm that external catalog table options have not been set
58855886
assert table.external_catalog_table_options is None
@@ -5888,26 +5889,13 @@ def test_external_catalog_table_options_getter(
58885889
table._properties[
58895890
"externalCatalogTableOptions"
58905891
] = external_catalog_table_options
5891-
table_repr = table.to_api_repr()
5892-
5892+
58935893
# Extract the ecto object.
5894-
ecto_output = table_repr["externalCatalogTableOptions"]
5894+
result = table.external_catalog_table_options
58955895

58965896
# Confirm that external catalog table options are an
58975897
# ExternalCatalogTableOptions object
5898-
assert isinstance(ecto_output, ExternalCatalogTableOptions)
5899-
5900-
storage_descriptor = request.getfixturevalue("_make_storage_descriptor")
5901-
5902-
expected = {
5903-
"connectionId": "connection123",
5904-
"parameters": {"key": "value"},
5905-
"storageDescriptor": storage_descriptor.to_api_repr(),
5906-
}
5907-
result = ecto_output.to_api_repr()
5908-
5909-
# Confirm that the api_repr of the ecto_output matches the inputs
5910-
print(f"DINOSAUR : {result}\n\n{expected}")
5898+
assert isinstance(result, ExternalCatalogTableOptions)
59115899
assert result == expected
59125900

59135901
def test_external_catalog_table_options_setter(

0 commit comments

Comments
 (0)