Skip to content

Commit c8b72ac

Browse files
committed
updates to correct coverage and fix tests
1 parent 0ac51f7 commit c8b72ac

File tree

2 files changed

+4
-25
lines changed

2 files changed

+4
-25
lines changed

tests/unit/test__helpers.py

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import google.api_core
2727
from google.cloud.bigquery._helpers import (
2828
_isinstance_or_raise,
29-
_from_api_repr,
3029
)
3130

3231

@@ -1695,25 +1694,5 @@ def test__valid_isinstance_or_raise(self, value, dtype, none_allowed, expected):
16951694
],
16961695
)
16971696
def test__invalid_isinstance_or_raise(self, value, dtype, none_allowed, expected):
1698-
with expected as e:
1699-
result = _isinstance_or_raise(value, dtype, none_allowed=none_allowed)
1700-
1701-
assert result == e
1702-
1703-
1704-
class _MockClass:
1705-
def __init__(self):
1706-
self._properties = {}
1707-
1708-
1709-
@pytest.fixture
1710-
def mock_class():
1711-
return _MockClass
1712-
1713-
1714-
class Test__from_api_repr:
1715-
def test_from_api_repr(self, mock_class):
1716-
resource = {"foo": "bar", "baz": {"qux": 1}}
1717-
config = _from_api_repr(mock_class, resource)
1718-
assert config._properties == resource
1719-
assert config._properties is not resource
1697+
with expected:
1698+
_isinstance_or_raise(value, dtype, none_allowed=none_allowed)

tests/unit/test_schema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1298,10 +1298,10 @@ def test_ctor_valid_input(
12981298
assert storage_descriptor.output_format == output_format
12991299
if serde_info is not None:
13001300
assert (
1301-
storage_descriptor.serde_info == serde_info.to_api_repr()
1301+
storage_descriptor.serde_info.to_api_repr() == serde_info.to_api_repr()
13021302
)
13031303
else:
1304-
assert storage_descriptor.serde_info == serde_info
1304+
assert storage_descriptor.serde_info is None
13051305

13061306
@pytest.mark.parametrize(
13071307
"input_format,location_uri,output_format,serde_info",

0 commit comments

Comments
 (0)