Skip to content

Commit ca36518

Browse files
committed
address reviewer feedback
1 parent 4ab55c6 commit ca36518

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

tests/unit/test__job_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,6 @@ def test_query_and_wait_sets_job_creation_mode():
601601

602602
def test_query_and_wait_sets_location():
603603
client = mock.create_autospec(Client)
604-
client.default_job_creation_mode = None
605604
client._call_api.return_value = {
606605
"jobReference": {
607606
"projectId": "response-project",
@@ -639,6 +638,7 @@ def test_query_and_wait_sets_location():
639638
"useInt64Timestamp": True,
640639
},
641640
"requestId": mock.ANY,
641+
"jobCreationMode": mock.ANY,
642642
},
643643
timeout=None,
644644
)

tests/unit/test_client.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,17 @@ def test_ctor_w_client_options_universe(self):
213213
)
214214
self.assertEqual(client._connection.API_BASE_URL, "https://bigquery.foo.com")
215215

216+
def test_ctor_w_job_creation_mode(self):
217+
creds = _make_credentials()
218+
http = object()
219+
client = self._make_one(
220+
project=self.PROJECT,
221+
credentials=creds,
222+
_http=http,
223+
default_job_creation_mode="foo",
224+
)
225+
self.assertEqual(client.default_job_creation_mode, "foo")
226+
216227
def test_ctor_w_location(self):
217228
from google.cloud.bigquery._http import Connection
218229

0 commit comments

Comments
 (0)