Updates comments and addes a to_api_repr test

Author: chalmerlowe

tests/unit/test_dataset.py

@@ -1052,13 +1052,23 @@ def test_external_catalog_dataset_options_getter(self):
         assert result == expected
 
     def test_external_catalog_dataset_options_from_api_repr(self):
+        resource = self.API_REPR
+        klass = self._get_target_class()
+        dataset = klass.from_api_repr(resource)
+        result = dataset.external_catalog_dataset_options.to_api_repr()
+        expected = resource["externalCatalogDatasetOptions"]
+        assert result == expected
+
+    def test_external_catalog_dataset_options_to_api_repr(self):
         resource = self.API_REPR
         klass = self._get_target_class()
         dataset = klass.from_api_repr(resource)
         result = dataset.external_catalog_dataset_options._properties
         expected = resource["externalCatalogDatasetOptions"]
         assert result == expected
 
+
+
     def test__build_resource_w_custom_field(self):
         dataset = self._make_one(self.DS_REF)
         dataset._properties["newAlphaProperty"] = "unreleased property"

tests/unit/test_external_config.py

@@ -939,10 +939,13 @@ def test_ctor_invalid_input(self):
         """Test ExternalCatalogDatasetOptions constructor with invalid input."""
         with pytest.raises(TypeError) as e:
             self._make_one(default_storage_location_uri=123)
+
+        # Looking for the first word from the string "Pass <variable> as..."
         assert "Pass " in str(e.value)
 
         with pytest.raises(TypeError) as e:
             self._make_one(parameters=123)
+        # Looking for the first word from the string "Pass <variable> as..."
         assert "Pass " in str(e.value)
 
     def test_to_api_repr(self):
@@ -1071,6 +1074,7 @@ def test_ctor_invalid_input(
                 storage_descriptor=storage_descriptor,
             )
 
+        # Looking for the first word from the string "Pass <variable> as..."
         assert "Pass " in str(e.value)
 
     def test_to_api_repr(self, _make_storage_descriptor):

tests/unit/test_schema.py

@@ -1144,7 +1144,9 @@ def test_ctor_valid_input(self, type_system, expected):
     def test_ctor_invalid_input(self):
         with pytest.raises(TypeError) as e:
             self._make_one(type_system=123)
-        assert "Pass" in str(e.value)
+
+        # Looking for the first word from the string "Pass <variable> as..."
+        assert "Pass " in str(e.value)
 
     @pytest.mark.parametrize(
         "type_system,expected",
@@ -1229,7 +1231,9 @@ def test_ctor_invalid_input(
                 output_format=output_format,
                 serde_info=serde_info,
             )
-        assert "Pass" in str(e.value)
+
+        # Looking for the first word from the string "Pass <variable> as..."
+        assert "Pass " in str(e.value)
 
     def test_to_api_repr(self):
         storage_descriptor = self._make_one(
@@ -1246,6 +1250,7 @@ def test_to_api_repr(self):
         }
 
         assert storage_descriptor.to_api_repr() == expected_repr
+    # TODO: needs a from_api_repr() test.
 
 
 class TestSerDeInfo:
@@ -1293,8 +1298,8 @@ def test_ctor_invalid_input(self, serialization_library, name, parameters):
                 name=name,
                 parameters=parameters,
             )
-
-        assert "Pass" in str(e.value)
+        # Looking for the first word from the string "Pass <variable> as..."
+        assert "Pass " in str(e.value)
 
     def test_to_api_repr(self):
         serde_info = self._make_one(
@@ -1308,3 +1313,5 @@ def test_to_api_repr(self):
             "parameters": {"key": "value"},
         }
         assert serde_info.to_api_repr() == expected_repr
+
+    # TODO: needs a from_api_repr() test.