update tests based on Schema superclass UserList

Author: chalmerlowe

google/cloud/bigquery/schema.py

@@ -17,7 +17,6 @@
 from __future__ import annotations
 
 import collections
-
 import copy
 import enum
 from typing import Any, cast, Dict, Iterable, Optional, Union

tests/unit/test_schema.py

@@ -851,21 +851,8 @@ def test_schema_fields_sequence(self):
 
     def test_unknown_properties(self):
         schema = [
-            {
-                "name": "full_name",
-                "type": "STRING",
-                "mode": "REQUIRED",
-                "someNewProperty": "test-value",
-            },
-            {
-                "name": "age",
-                # Note: This type should be included, too. Avoid client-side
-                # validation, as it could prevent backwards-compatible
-                # evolution of the server-side behavior.
-                "typo": "INTEGER",
-                "mode": "REQUIRED",
-                "anotherNewProperty": "another-test",
-            },
+            {"name": "full_name", "type": "STRING", "mode": "REQUIRED"},
+            {"name": "address", "invalid_key": "STRING", "mode": "REQUIRED"},
         ]
         with pytest.raises(Exception):  # Or a more specific exception if known
             _to_schema_fields(schema)
@@ -908,7 +895,7 @@ def test_valid_mapping_representation(self, schema, expected_schema):
 
     def test_valid_schema_object(self):
         schema = Schema(
-            fields=[SchemaField("name", "STRING")],
+            fields=[SchemaField("name", "STRING", description=None, policy_tags=None)],
             foreign_type_info="TestInfo",
         )
         result = _to_schema_fields(schema)
@@ -919,7 +906,6 @@ def test_valid_schema_object(self):
         assert result.to_api_repr() == expected.to_api_repr()
 
 
-# Testing the new Schema Class =================
 class TestSchemaObject:  # New test class for Schema object interactions
     def test_schema_object_field_access(self):
         schema = Schema(
@@ -928,9 +914,10 @@ def test_schema_object_field_access(self):
                 SchemaField("age", "INTEGER"),
             ]
         )
+
         assert len(schema) == 2
-        assert schema[0].name == "name"  # Access fields using indexing
-        assert schema[1].field_type == "INTEGER"
+        assert schema[0]["name"] == "name"  # Access fields using indexing
+        assert schema[1]["type"] == "INTEGER"
 
     def test_schema_object_foreign_type_info(self):
         schema = Schema(foreign_type_info="External")
@@ -949,7 +936,7 @@ def test_str(self):
         )
         assert (
             str(schema)
-            == "Schema([SchemaField('name', 'STRING', 'NULLABLE', None, None, (), None)], TestInfo)"
+            == "Schema([{'name': 'name', 'mode': 'NULLABLE', 'type': 'STRING'}], TestInfo)"
         )
 
     @pytest.mark.parametrize(
@@ -960,12 +947,12 @@ def test_str(self):
                     fields=[SchemaField("name", "STRING")],
                     foreign_type_info="TestInfo",
                 ),
-                "Schema([SchemaField('name', 'STRING', 'NULLABLE', None, None, (), None)], 'TestInfo')",
+                "Schema([{'name': 'name', 'mode': 'NULLABLE', 'type': 'STRING'}], 'TestInfo')",
                 id="repr with foreign type info",
             ),
             pytest.param(
                 Schema(fields=[SchemaField("name", "STRING")]),
-                "Schema([SchemaField('name', 'STRING', 'NULLABLE', None, None, (), None)], None)",
+                "Schema([{'name': 'name', 'mode': 'NULLABLE', 'type': 'STRING'}], None)",
                 id="repr without foreign type info",
             ),
         ],
@@ -977,8 +964,7 @@ def test_schema_iteration(self):
         schema = Schema(
             fields=[SchemaField("name", "STRING"), SchemaField("age", "INTEGER")]
         )
-
-        field_names = [field.name for field in schema]
+        field_names = [field["name"] for field in schema]
         assert field_names == ["name", "age"]
 
     def test_schema_object_mutability(self):  # Tests __setitem__ and __delitem__
@@ -1021,19 +1007,15 @@ def test_schema_extend(self):
                     foreign_type_info="TestInfo",
                 ),
                 {
-                    "_fields": [
-                        SchemaField("name", "STRING", "NULLABLE", None, None, (), None)
-                    ],
+                    "fields": [{"name": "name", "mode": "NULLABLE", "type": "STRING"}],
                     "foreignTypeInfo": "TestInfo",
                 },
                 id="repr with foreign type info",
             ),
             pytest.param(
                 Schema(fields=[SchemaField("name", "STRING")]),
                 {
-                    "_fields": [
-                        SchemaField("name", "STRING", "NULLABLE", None, None, (), None)
-                    ],
+                    "fields": [{"name": "name", "mode": "NULLABLE", "type": "STRING"}],
                     "foreignTypeInfo": None,
                 },
                 id="repr without foreign type info",
@@ -1048,25 +1030,35 @@ def test_to_api_repr(self, schema, expected_api_repr):
         [
             pytest.param(
                 {
-                    "_fields": [
+                    "fields": [
                         SchemaField("name", "STRING", "NULLABLE", None, None, (), None)
                     ],
                     "foreignTypeInfo": "TestInfo",
                 },
                 Schema(
-                    fields=[SchemaField("name", "STRING")],
+                    fields=[
+                        SchemaField(
+                            "name", "STRING", description=None, policy_tags=None
+                        )
+                    ],
                     foreign_type_info="TestInfo",
                 ),
                 id="repr with foreign type info",
             ),
             pytest.param(
                 {
-                    "_fields": [
+                    "fields": [
                         SchemaField("name", "STRING", "NULLABLE", None, None, (), None)
                     ],
                     "foreignTypeInfo": None,
                 },
-                Schema(fields=[SchemaField("name", "STRING")]),
+                Schema(
+                    fields=[
+                        SchemaField(
+                            "name", "STRING", description=None, policy_tags=None
+                        )
+                    ]
+                ),
                 id="repr without foreign type info",
             ),
         ],
@@ -1078,13 +1070,11 @@ def test_from_api_repr(self, api_repr, expected):
         THEN it will have the same representation a Schema object created
         directly and displayed as a dict.
         """
+
         result = Schema.from_api_repr(api_repr)
         assert result.to_api_repr() == expected.to_api_repr()
 
 
-# END PYTEST BASED SCHEMA TESTS ====================
-
-
 class TestPolicyTags(unittest.TestCase):
     @staticmethod
     def _get_target_class():