Skip to content

chore: librarian update image pull request: 20260113T171106Z #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parthea merged 1 commit into from
Jan 13, 2026
Merged

chore: librarian update image pull request: 20260113T171106Z #663

parthea merged 1 commit into from
Jan 13, 2026

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 13, 2026 •
edited
Loading

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8

This PR was created by running librarian update-image -push

@parthea
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-…
4ddb192 
…prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8
@parthea parthea requested review from a team as code owners January 13, 2026 17:11
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 13, 2026
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Jan 13, 2026
@gemini-code-assist
Copy link

gemini-code-assist bot commented Jan 13, 2026

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the python-librarian-generator image to its latest version, which ensures that the project utilizes the most current tooling. Concurrently, it refactors the credential handling mechanism within the Datastore client transports by streamlining how authentication scopes are passed, leading to cleaner and more direct code for credential management.

Highlights

  • Librarian Image Update: The python-librarian-generator image has been updated to a new SHA256 hash in the .librarian/state.yaml file, ensuring the use of the latest version of the generator.
  • Credential Handling Refactor: The scopes_kwargs dictionary has been removed from the __init__ methods of DatastoreAdminTransport and DatastoreTransport base classes. Authentication scopes and default_scopes are now passed directly as keyword arguments to google.auth.load_credentials_from_file and google.auth.default functions, simplifying the credential loading logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 13, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by the librarian tool, updates the generator image and refactors how authentication scopes are handled in the transport base classes. The change removes the scopes_kwargs dictionary and instead passes the scopes and default_scopes arguments explicitly to google.auth functions. This is a good refactoring that improves code readability and maintainability. The changes look correct and I see no issues.

@parthea parthea merged commit e2f4d13 into main Jan 13, 2026
31 checks passed
@parthea parthea deleted the librarian-20260113T171106Z branch January 13, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pcostell pcostell

Labels

api: datastore Issues related to the googleapis/python-datastore API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @gkevinzheng @pcostell