Replace usage of google.api.core with google.api_core (#4221)

* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core.

* s/google.api.core/google.api_core/g and nox updates

* Fixing core tests, addressing review feedback

* Fix bigquery

Author: Jon Wayne Parrott

google/cloud/logging/_gax.py

@@ -16,7 +16,7 @@
 
 import functools
 
-from google.api.core import page_iterator
+from google.api_core import page_iterator
 from google.cloud.gapic.logging.v2.config_service_v2_client import (
     ConfigServiceV2Client)
 from google.cloud.gapic.logging.v2.logging_service_v2_client import (
@@ -84,7 +84,7 @@ def list_entries(self, projects, filter_='', order_by='',
                            passed, the API will return the first page of
                            entries.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of :class:`~google.cloud.logging.entries._BaseEntry`
                   accessible to the current API.
         """
@@ -332,7 +332,7 @@ def list_metrics(self, project, page_size=0, page_token=None):
                            passed, the API will return the first page of
                            metrics.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of
                   :class:`~google.cloud.logging.metric.Metric`
                   accessible to the current API.
@@ -510,12 +510,12 @@ def _item_to_entry(iterator, entry_pb, loggers):
 
         This method does not have the correct signature to be used as
         the ``item_to_value`` argument to
-        :class:`~google.api.core.page_iterator.Iterator`. It is intended to be
+        :class:`~google.api_core.page_iterator.Iterator`. It is intended to be
         patched with a mutable ``loggers`` argument that can be updated
         on subsequent calls. For an example, see how the method is
         used above in :meth:`_LoggingAPI.list_entries`.
 
-    :type iterator: :class:`~google.api.core.page_iterator.Iterator`
+    :type iterator: :class:`~google.api_core.page_iterator.Iterator`
     :param iterator: The iterator that is currently in use.
 
     :type entry_pb: :class:`.log_entry_pb2.LogEntry`
@@ -537,7 +537,7 @@ def _item_to_entry(iterator, entry_pb, loggers):
 def _item_to_sink(iterator, log_sink_pb):
     """Convert a sink protobuf to the native object.
 
-    :type iterator: :class:`~google.api.core.page_iterator.Iterator`
+    :type iterator: :class:`~google.api_core.page_iterator.Iterator`
     :param iterator: The iterator that is currently in use.
 
     :type log_sink_pb:
@@ -556,7 +556,7 @@ def _item_to_sink(iterator, log_sink_pb):
 def _item_to_metric(iterator, log_metric_pb):
     """Convert a metric protobuf to the native object.
 
-    :type iterator: :class:`~google.api.core.page_iterator.Iterator`
+    :type iterator: :class:`~google.api_core.page_iterator.Iterator`
     :param iterator: The iterator that is currently in use.
 
     :type log_metric_pb:

google/cloud/logging/_http.py

@@ -16,7 +16,7 @@
 
 import functools
 
-from google.api.core import page_iterator
+from google.api_core import page_iterator
 from google.cloud import _http
 
 from google.cloud.logging import __version__
@@ -93,7 +93,7 @@ def list_entries(self, projects, filter_=None, order_by=None,
                            passed, the API will return the first page of
                            entries.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of :class:`~google.cloud.logging.entries._BaseEntry`
                   accessible to the current API.
         """
@@ -209,7 +209,7 @@ def list_sinks(self, project, page_size=None, page_token=None):
                            passed, the API will return the first page of
                            sinks.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of
                   :class:`~google.cloud.logging.sink.Sink`
                   accessible to the current API.
@@ -353,7 +353,7 @@ def list_metrics(self, project, page_size=None, page_token=None):
                            passed, the API will return the first page of
                            metrics.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of
                   :class:`~google.cloud.logging.metric.Metric`
                   accessible to the current API.
@@ -471,12 +471,12 @@ def _item_to_entry(iterator, resource, loggers):
 
         This method does not have the correct signature to be used as
         the ``item_to_value`` argument to
-        :class:`~google.api.core.page_iterator.Iterator`. It is intended to be
+        :class:`~google.api_core.page_iterator.Iterator`. It is intended to be
         patched with a mutable ``loggers`` argument that can be updated
         on subsequent calls. For an example, see how the method is
         used above in :meth:`_LoggingAPI.list_entries`.
 
-    :type iterator: :class:`~google.api.core.page_iterator.Iterator`
+    :type iterator: :class:`~google.api_core.page_iterator.Iterator`
     :param iterator: The iterator that is currently in use.
 
     :type resource: dict
@@ -497,7 +497,7 @@ def _item_to_entry(iterator, resource, loggers):
 def _item_to_sink(iterator, resource):
     """Convert a sink resource to the native object.
 
-    :type iterator: :class:`~google.api.core.page_iterator.Iterator`
+    :type iterator: :class:`~google.api_core.page_iterator.Iterator`
     :param iterator: The iterator that is currently in use.
 
     :type resource: dict
@@ -512,7 +512,7 @@ def _item_to_sink(iterator, resource):
 def _item_to_metric(iterator, resource):
     """Convert a metric resource to the native object.
 
-    :type iterator: :class:`~google.api.core.page_iterator.Iterator`
+    :type iterator: :class:`~google.api_core.page_iterator.Iterator`
     :param iterator: The iterator that is currently in use.
 
     :type resource: dict

google/cloud/logging/client.py

@@ -195,7 +195,7 @@ def list_entries(self, projects=None, filter_=None, order_by=None,
                            passed, the API will return the first page of
                            entries.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of :class:`~google.cloud.logging.entries._BaseEntry`
                   accessible to the current client.
         """
@@ -244,7 +244,7 @@ def list_sinks(self, page_size=None, page_token=None):
                            passed, the API will return the first page of
                            sinks.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of
                   :class:`~google.cloud.logging.sink.Sink`
                   accessible to the current client.
@@ -289,7 +289,7 @@ def list_metrics(self, page_size=None, page_token=None):
                            passed, the API will return the first page of
                            metrics.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of :class:`~google.cloud.logging.metric.Metric`
                   accessible to the current client.
         """

google/cloud/logging/logger.py

@@ -344,7 +344,7 @@ def list_entries(self, projects=None, filter_=None, order_by=None,
                            passed, the API will return the first page of
                            entries.
 
-        :rtype: :class:`~google.api.core.page_iterator.Iterator`
+        :rtype: :class:`~google.api_core.page_iterator.Iterator`
         :returns: Iterator of :class:`~google.cloud.logging.entries._BaseEntry`
                   accessible to the current logger.
         """

nox.py

@@ -19,7 +19,10 @@
 import nox
 
 
-LOCAL_DEPS = ('../core/',)
+LOCAL_DEPS = (
+    os.path.join('..', 'api_core'),
+    os.path.join('..', 'core'),
+)
 
 
 @nox.session