Re-enable lint for tests, remove usage of pylint (#4921)

Author: Jon Wayne Parrott

.flake8

@@ -1,5 +1,11 @@
 [flake8]
 exclude =
+  # Exclude generated code.
+  **/proto/**
+  **/gapic/**
+  *_pb2.py
+
+  # Standard linting exemptions.
   __pycache__,
   .git,
   *.pyc,

nox.py

@@ -124,16 +124,9 @@ def lint(session):
     serious code quality issues.
     """
     session.interpreter = 'python3.6'
-    session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
+    session.install('flake8')
     session.install('.')
-    session.run('flake8', 'google/cloud/logging')
-    session.run(
-        'gcp-devrel-py-tools', 'run-pylint',
-        '--config', 'pylint.config.py',
-        '--library-filesets', 'google',
-        '--test-filesets', 'tests',
-        # Temporarily allow this to fail.
-        success_codes=range(0, 100))
+    session.run('flake8', 'google', 'tests')
 
 
 @nox.session

tests/unit/handlers/test__helpers.py

@@ -80,7 +80,6 @@ def get(self):
         self.response.out.write(json.dumps(trace_id))
 
 
-
 @unittest.skipIf(six.PY3, 'webapp2 is Python 2 only')
 class Test_get_trace_id_from_webapp2(unittest.TestCase):
 

tests/unit/handlers/test_app_engine.py

@@ -33,7 +33,6 @@ def test_constructor(self):
         from google.cloud.logging.handlers.app_engine import _GAE_PROJECT_ENV
         from google.cloud.logging.handlers.app_engine import _GAE_SERVICE_ENV
         from google.cloud.logging.handlers.app_engine import _GAE_VERSION_ENV
-        from google.cloud.logging.handlers.app_engine import _TRACE_ID_LABEL
 
         client = mock.Mock(project=self.PROJECT, spec=['project'])
 

tests/unit/handlers/test_handlers.py

@@ -38,7 +38,8 @@ def test_emit(self):
         from google.cloud.logging.logger import _GLOBAL_RESOURCE
 
         client = _Client(self.PROJECT)
-        handler = self._make_one(client, transport=_Transport, resource=_GLOBAL_RESOURCE)
+        handler = self._make_one(
+            client, transport=_Transport, resource=_GLOBAL_RESOURCE)
         logname = 'loggername'
         message = 'hello world'
         record = logging.LogRecord(logname, logging, None, None, message,

tests/unit/handlers/transports/test_background_thread.py

@@ -380,7 +380,8 @@ def __init__(self):
         self.commit_called = False
         self.commit_count = None
 
-    def log_struct(self, info, severity=logging.INFO, resource=None, labels=None):
+    def log_struct(
+            self, info, severity=logging.INFO, resource=None, labels=None):
         from google.cloud.logging.logger import _GLOBAL_RESOURCE
 
         assert resource is None

tests/unit/test_logger.py

@@ -573,8 +573,9 @@ def test_log_text_explicit(self):
             type='gae_app',
             labels={
                 'module_id': 'default',
-                'version_id': 'test',
-        })
+                'version_id': 'test'
+            }
+        )
 
         client = _Client(project=self.PROJECT, connection=_make_credentials())
         logger = _Logger()
@@ -632,7 +633,7 @@ def test_log_struct_explicit(self):
                          timestamp=TIMESTAMP, resource=RESOURCE)
         self.assertEqual(
             batch.entries,
-            [('struct', STRUCT, LABELS, IID, SEVERITY, REQUEST, TIMESTAMP ,
+            [('struct', STRUCT, LABELS, IID, SEVERITY, REQUEST, TIMESTAMP,
               RESOURCE)])
 
     def test_log_proto_defaults(self):
@@ -732,7 +733,6 @@ def test_commit_w_bound_client(self):
         from google.cloud._helpers import _datetime_to_rfc3339
         from google.cloud.logging.logger import _GLOBAL_RESOURCE
 
-
         TEXT = 'This is the entry text'
         STRUCT = {'message': TEXT, 'weather': 'partly cloudy'}
         message = Struct(fields={'foo': Value(bool_value=True)})
@@ -825,7 +825,6 @@ def test_context_mgr_success(self):
         from google.cloud.logging.logger import Logger
         from google.cloud.logging.logger import _GLOBAL_RESOURCE
 
-
         TEXT = 'This is the entry text'
         STRUCT = {'message': TEXT, 'weather': 'partly cloudy'}
         message = Struct(fields={'foo': Value(bool_value=True)})