Skip to content

Commit ac210e7

Browse files
authored
Remove gRPC size restrictions (4MB default) (#8860)
1 parent a57977a commit ac210e7

File tree

5 files changed

+37
-8
lines changed

5 files changed

+37
-8
lines changed

google/cloud/logging_v2/gapic/transports/config_service_v2_grpc_transport.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,14 @@ def __init__(
6464

6565
# Create the channel.
6666
if channel is None:
67-
channel = self.create_channel(address=address, credentials=credentials)
67+
channel = self.create_channel(
68+
address=address,
69+
credentials=credentials,
70+
options={
71+
"grpc.max_send_message_length": -1,
72+
"grpc.max_receive_message_length": -1,
73+
}.items(),
74+
)
6875

6976
self._channel = channel
7077

google/cloud/logging_v2/gapic/transports/logging_service_v2_grpc_transport.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,14 @@ def __init__(
6464

6565
# Create the channel.
6666
if channel is None:
67-
channel = self.create_channel(address=address, credentials=credentials)
67+
channel = self.create_channel(
68+
address=address,
69+
credentials=credentials,
70+
options={
71+
"grpc.max_send_message_length": -1,
72+
"grpc.max_receive_message_length": -1,
73+
}.items(),
74+
)
6875

6976
self._channel = channel
7077

google/cloud/logging_v2/gapic/transports/metrics_service_v2_grpc_transport.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,14 @@ def __init__(
6464

6565
# Create the channel.
6666
if channel is None:
67-
channel = self.create_channel(address=address, credentials=credentials)
67+
channel = self.create_channel(
68+
address=address,
69+
credentials=credentials,
70+
options={
71+
"grpc.max_send_message_length": -1,
72+
"grpc.max_receive_message_length": -1,
73+
}.items(),
74+
)
6875

6976
self._channel = channel
7077

synth.metadata

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
{
2-
"updateTime": "2019-07-10T12:23:32.614992Z",
2+
"updateTime": "2019-08-01T00:00:23.364082Z",
33
"sources": [
44
{
55
"generator": {
66
"name": "artman",
7-
"version": "0.29.4",
8-
"dockerImage": "googleapis/artman@sha256:63f21e83cb92680b7001dc381069e962c9e6dee314fd8365ac554c07c89221fb"
7+
"version": "0.31.0",
8+
"dockerImage": "googleapis/artman@sha256:9aed6bbde54e26d2fcde7aa86d9f64c0278f741e58808c46573e488cbf6098f0"
99
}
1010
},
1111
{
1212
"git": {
1313
"name": "googleapis",
1414
"remote": "https://github.com/googleapis/googleapis.git",
15-
"sha": "16c0ea3cde17a897ba04b7b94d9bf4dd57e3227e",
16-
"internalRef": "257239177"
15+
"sha": "e3b51e761db720974bc153a380a2f7ae5baee43d",
16+
"internalRef": "260992170"
1717
}
1818
},
1919
{

synth.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,14 @@
3838
# https://github.com/googleapis/gapic-generator/issues/2097
3939
s.replace("google/**/proto/*_pb2.py", r"(^.*$\n)*", r"# -*- coding: utf-8 -*-\n\g<0>")
4040

41+
# the logging service grpc transport channel shouldn't limit the size of a grpc message at the default 4mb
42+
s.replace("google/cloud/logging_v2/gapic/transports/*_service_v2_grpc_transport.py",
43+
"channel =.*\n(\s+)address=.*\n\s+credentials=.*,\n",
44+
"\g<0>\g<1>options={\n"
45+
"\g<1> 'grpc.max_send_message_length': -1,\n"
46+
"\g<1> 'grpc.max_receive_message_length': -1,\n"
47+
"\g<1>}.items(),\n")
48+
4149
# ----------------------------------------------------------------------------
4250
# Add templated files
4351
# ----------------------------------------------------------------------------

0 commit comments

Comments
 (0)