Skip to content

Commit ba55ff6

Browse files
chore: new owl bot post processor docker image (#287)
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:457583330eec64daa02aeb7a72a04d33e7be2428f646671ce4045dcbc0191b1e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent e225c63 commit ba55ff6

File tree

4 files changed

+6
-31
lines changed

4 files changed

+6
-31
lines changed

.github/.OwlBot.lock.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
docker:
2-
digest: sha256:cfc0e802701262c211703c468874d767f65dabe6a1a71d0e07bfc8a3d5175f32
3-
image: gcr.io/repo-automation-bots/owlbot-python:latest
4-
2+
image: gcr.io/repo-automation-bots/owlbot-python:latest
3+
digest: sha256:457583330eec64daa02aeb7a72a04d33e7be2428f646671ce4045dcbc0191b1e

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ repos:
2626
hooks:
2727
- id: black
2828
- repo: https://gitlab.com/pycqa/flake8
29-
rev: 3.9.0
29+
rev: 3.9.1
3030
hooks:
3131
- id: flake8

CONTRIBUTING.rst

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -160,21 +160,7 @@ Running System Tests
160160
auth settings and change some configuration in your project to
161161
run all the tests.
162162

163-
- System tests will be run against an actual project and
164-
so you'll need to provide some environment variables to facilitate
165-
authentication to your project:
166-
167-
- ``GOOGLE_APPLICATION_CREDENTIALS``: The path to a JSON key file;
168-
Such a file can be downloaded directly from the developer's console by clicking
169-
"Generate new JSON key". See private key
170-
`docs <https://cloud.google.com/storage/docs/authentication#generating-a-private-key>`__
171-
for more details.
172-
173-
- Once you have downloaded your json keys, set the environment variable
174-
``GOOGLE_APPLICATION_CREDENTIALS`` to the absolute path of the json file::
175-
176-
$ export GOOGLE_APPLICATION_CREDENTIALS="/Users/<your_username>/path/to/app_credentials.json"
177-
163+
- System tests will be run against an actual project. You should use local credentials from gcloud when possible. See `Best practices for application authentication <https://cloud.google.com/docs/authentication/best-practices-applications#local_development_and_testing_with_the>`__. Some tests require a service account. For those tests see `Authenticating as a service account <https://cloud.google.com/docs/authentication/production>`__.
178164

179165
*************
180166
Test Coverage

noxfile.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,9 @@ def lint(session):
6262
session.run("flake8", "google", "tests")
6363

6464

65-
@nox.session(python="3.6")
65+
@nox.session(python=DEFAULT_PYTHON_VERSION)
6666
def blacken(session):
67-
"""Run black.
68-
69-
Format code to uniform standard.
70-
71-
This currently uses Python 3.6 due to the automated Kokoro run of synthtool.
72-
That run uses an image that doesn't have 3.6 installed. Before updating this
73-
check the state of the `gcp_ubuntu_config` we use for that Kokoro run.
74-
"""
67+
"""Run black. Format code to uniform standard."""
7568
session.install(BLACK_VERSION)
7669
session.run(
7770
"black", *BLACK_PATHS,
@@ -140,9 +133,6 @@ def system(session):
140133
# Check the value of `RUN_SYSTEM_TESTS` env var. It defaults to true.
141134
if os.environ.get("RUN_SYSTEM_TESTS", "true") == "false":
142135
session.skip("RUN_SYSTEM_TESTS is set to false, skipping")
143-
# Sanity check: Only run tests if the environment variable is set.
144-
if not os.environ.get("GOOGLE_APPLICATION_CREDENTIALS", ""):
145-
session.skip("Credentials must be set via environment variable")
146136
# Install pyopenssl for mTLS testing.
147137
if os.environ.get("GOOGLE_API_USE_CLIENT_CERTIFICATE", "false") == "true":
148138
session.install("pyopenssl")

0 commit comments

Comments
 (0)