Commit 4bd3d1d
authored
docs: open file-like objects in byte mode for uploads (#824)
File-like objects should be opened in binary mode for `blob.upload_from_file()`
- cpython standard library accorded with [RFC 2616 Section 3.7.1](https://datatracker.ietf.org/doc/html/rfc2616#section-3.7.1) states the text default charset of iso-8859-1
- add clarifying notes in docstring
- update code sample
Fixes #818 🦕1 parent 5e06dc0 commit 4bd3d1d
File tree
2 files changed
+3
-3
lines changed- google/cloud/storage
- samples/snippets
2 files changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2456 | 2456 | | |
2457 | 2457 | | |
2458 | 2458 | | |
2459 | | - | |
| 2459 | + | |
2460 | 2460 | | |
2461 | 2461 | | |
2462 | 2462 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
| 28 | + | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
0 commit comments