resolving comments

Author: shubham-up-47

google/cloud/storage/_media/_download.py

@@ -140,7 +140,7 @@ class Download(DownloadBase):
             ``start`` to the end of the media.
         headers (Optional[Mapping[str, str]]): Extra headers that should
             be sent with the request, e.g. headers for encrypted data.
-        checksum Optional([str]): The type of checksum to compute to verify
+        checksum (Optional[str]): The type of checksum to compute to verify
             the integrity of the object. The response headers must contain
             a checksum of the requested type. If the headers lack an
             appropriate checksum (for instance in the case of transcoded or
@@ -157,6 +157,9 @@ class Download(DownloadBase):
             See the retry.py source code and docstrings in this package
             (google.cloud.storage.retry) for information on retry types and how
             to configure them.
+        single_shot_download (Optional[bool]): If true, download the object in a single request.
+            Caution: Enabling this will increase the memory overload for your application.
+            Please enable this as per your use case.
 
     """
 

google/cloud/storage/blob.py

@@ -1081,6 +1081,9 @@ def _do_download(
                 end=end,
                 checksum=checksum,
                 retry=retry,
+                # NOTE: single_shot_download is only supported in Download and RawDownload
+                # classes, i.e., when chunk_size is set to None (the default value). It is
+                # not supported for chunked downloads.
                 single_shot_download=single_shot_download,
             )
             with create_trace_span(

tests/resumable_media/system/requests/test_download.py

@@ -323,7 +323,8 @@ def test_download_to_stream(self, add_files, authorized_transport):
             assert stream.getvalue() == actual_contents
             check_tombstoned(download, authorized_transport)
 
-    def test_single_shot_download_to_stream(self, add_files, authorized_transport):
+    @pytest.mark.parametrize("checksum", ["auto", "md5", "crc32c", None])
+    def test_single_shot_download_to_stream(self, add_files, authorized_transport, checksum):
         for info in ALL_FILES:
             actual_contents = self._get_contents(info)
             blob_name = get_blob_name(info)
@@ -332,7 +333,7 @@ def test_single_shot_download_to_stream(self, add_files, authorized_transport):
             media_url = utils.DOWNLOAD_URL_TEMPLATE.format(blob_name=blob_name)
             stream = io.BytesIO()
             download = self._make_one(
-                media_url, stream=stream, single_shot_download=True
+                media_url, checksum=checksum, stream=stream, single_shot_download=True
             )
             # Consume the resource with single_shot_download enabled.
             response = download.consume(authorized_transport)