Skip to content

Commit 9cb92af

Browse files
committed
PR feedback
1 parent 850fbe4 commit 9cb92af

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

.gitignore

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,3 @@ __pycache__
88
package-lock.json
99
debug.sh
1010
.idea/
11-
12-
# Devenv
13-
.devenv*
14-
devenv.local.nix
15-
devenv.lock
16-
devenv.nix
17-
devenv.yaml
18-
.envrc
19-
20-
# direnv
21-
.direnv
22-

docs/customizing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ version given a list of parsed commits.
4444
| `always-bump-minor` | Always bump minor version | |
4545
| `always-bump-major` | Always bump major version |
4646
| `service-pack` | Designed for Java backport fixes. Uses Maven's specification for service pack versions (e.g. 1.2.3-sp.1) |
47-
| `prerelease` | Bumping prerelease number (eg. 1.2.0-beta01 to 1.2.0-beta02) or if prerelease type is set, using that in the prerelease part (eg. 1.2.1 to 1.3.0-beta). Works together with the "prerelease" settings from [manifest-releaser](/docs/manifest-releaser.md) (see for more infos) - a prerelease version number will only be created, if the prerelease setting is set to true (false by default). |
47+
| `prerelease` | Bumping prerelease number (eg. 1.2.0-beta01 to 1.2.0-beta02) or if prerelease type is set, using that in the prerelease part (eg. 1.2.1 to 1.3.0-beta). Works together with the "prerelease" settings from [manifest-releaser](/docs/manifest-releaser.md) (see for more infos) - A prerelease version number will only be created if the prerelease setting is set to `true`. Default: `false`. For more information, see [Manifest Driven release-please](manifest-releaser.md). |
4848

4949
### Adding additional versioning strategy types
5050

docs/manifest-releaser.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,9 @@ defaults (those are documented in comments)
199199
// absence defaults to false and all versions are fully Published.
200200
// Works together with the "prerelease" versioning strategy, which creates a
201201
// prerelease-version (like 1.0.0-alpha.1) only if this setting is set to true.
202-
// This allows to create prerelease-versions on conditions (e.g. publish them only
203-
// on release-candidate branches)
202+
// This allows to create prerelease-versions while working on pre-release branches -
203+
// once the development is done and the branch gets merged to main/release-branch
204+
// a full-release can be done.
204205
"prerelease": true
205206

206207
// Skip creating GitHub Releases

test/versioning-strategies/prerelease.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,9 @@ describe('PrereleaseVersioningStrategy', () => {
132132
describe('without prerelease property', () => {
133133
const expectedBumps: Record<string, string> = {
134134
'1.2.3': '2.0.0',
135-
'1.0.0-beta01': '1.0.0',
135+
// beta01 indicates that there had to be a breaking change with prerelease=true.
136+
// e.g. coong from 0.1.0 -> feat! (prerelease=True) -> 1.0.0-beta01 -> prerelease=False -> 1.0.0
137+
'1.0.0-beta01': '1.0.0',
136138
'1.1.0-beta01': '2.0.0',
137139
'1.3.0-alpha': '2.0.0',
138140
'1.3.0-alpha.1': '2.0.0',

0 commit comments

Comments
 (0)