Skip to content

Commit 0823d90

Browse files
committed
fix: potential file descriptor leak
1 parent be36414 commit 0823d90

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

internal/librariangen/generate/generator.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -248,16 +248,19 @@ func unzip(src, dest string) error {
248248

249249
rc, err := f.Open()
250250
if err != nil {
251+
outFile.Close()
251252
return err
252253
}
253254

254-
_, err = io.Copy(outFile, rc)
255+
_, copyErr := io.Copy(outFile, rc)
256+
rc.Close() // Error on read-only file close is less critical
257+
closeErr := outFile.Close()
255258

256-
outFile.Close()
257-
rc.Close()
258-
259-
if err != nil {
260-
return err
259+
if copyErr != nil {
260+
return copyErr
261+
}
262+
if closeErr != nil {
263+
return closeErr
261264
}
262265
}
263266
return nil

0 commit comments

Comments
 (0)