Skip to content

Commit 20f9f5a

Browse files
committed
remove redundant code.
1 parent 7901d8a commit 20f9f5a

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcLoggingInterceptor.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,7 @@ public void onMessage(RespT message) {
8484

8585
@Override
8686
public void onClose(Status status, Metadata trailers) {
87-
try {
88-
logResponse(status, logDataBuilder, LOGGER);
89-
} finally {
90-
logDataBuilder = null; // release resource
91-
}
87+
logResponse(status, logDataBuilder, LOGGER);
9288
super.onClose(status, trailers);
9389
}
9490
};
@@ -156,7 +152,6 @@ <RespT> void recordResponsePayload(RespT message, LogData.Builder logDataBuilder
156152

157153
void logResponse(Status status, LogData.Builder logDataBuilder, Logger logger) {
158154
try {
159-
160155
if (logger.isInfoEnabled()) {
161156
logDataBuilder.responseStatus(status.getCode().toString());
162157
}

gax-java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonLoggingInterceptor.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,7 @@ public void onMessage(RespT message) {
8585

8686
@Override
8787
public void onClose(int statusCode, HttpJsonMetadata trailers) {
88-
try {
89-
logResponse(statusCode, logDataBuilder, LOGGER);
90-
} finally {
91-
logDataBuilder = null; // release resource
92-
}
88+
logResponse(statusCode, logDataBuilder, LOGGER);
9389
super.onClose(statusCode, trailers);
9490
}
9591
};

0 commit comments

Comments
 (0)