Skip to content

Commit 2c5e527

Browse files
committed
chore: Remove local install repo from source test
1 parent 594e5a8 commit 2c5e527

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
- name: Print Protobuf-Java testing version
6464
run: echo "Testing with Protobuf-Java v${{ matrix.protobuf-version }}"
6565
- name: Perform downstream source compatibility testing
66-
run: REPOS_UNDER_TEST="${{ matrix.repo }}" PROTOBUF_RUNTIME_VERSION="${{ matrix.protobuf-version }}" REPOS_INSTALLED_LOCALLY="true" ./.kokoro/nightly/downstream-protobuf-source-compatibility.sh
66+
run: REPOS_UNDER_TEST="${{ matrix.repo }}" PROTOBUF_RUNTIME_VERSION="${{ matrix.protobuf-version }}" ./.kokoro/nightly/downstream-protobuf-source-compatibility.sh
6767
- name: Perform downstream binary compatibility testing
6868
run: REPOS_UNDER_TEST="${{ matrix.repo }}" PROTOBUF_RUNTIME_VERSION="${{ matrix.protobuf-version }}" REPOS_INSTALLED_LOCALLY="true" ./.kokoro/nightly/downstream-protobuf-binary-compatibility.sh
6969

.kokoro/nightly/downstream-protobuf-source-compatibility.sh

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,9 @@
1515

1616
set -eo pipefail
1717

18-
# There are three Env Vars that this script uses.
18+
# There are two Env Vars that this script uses.
1919
# 1. (Required) REPOS_UNDER_TEST: Comma separate list of the repo names
2020
# 2. (Required) PROTOBUF_RUNTIME_VERSION: Protobuf runtime version to test again
21-
# 3. REPOS_INSTALLED_LOCALLY: Flag (if set to "true) will determine if the repo
22-
# needs to be cloned from github and re-installed locally to the m2. If the artifact
23-
# is already installed locally, this saves time as the artifact is not again compiled
24-
# and built.
2521

2622
# Comma-delimited list of repos to test with the local java-shared-dependencies
2723
if [ -z "${REPOS_UNDER_TEST}" ]; then
@@ -38,16 +34,13 @@ if [ -z "${PROTOBUF_RUNTIME_VERSION}" ]; then
3834
fi
3935

4036
for repo in ${REPOS_UNDER_TEST//,/ }; do # Split on comma
41-
if [ "${REPOS_INSTALLED_LOCALLY}" != "true" ]; then
42-
# Perform source-compatibility testing on main (latest changes)
43-
git clone "https://github.com/googleapis/$repo.git" --depth=1
44-
fi
45-
37+
# Perform source-compatibility testing on main (latest changes)
38+
git clone "https://github.com/googleapis/$repo.git" --depth=1
4639
pushd "$repo"
4740

4841
# Compile the Handwritten Library with the Protobuf-Java version to test source compatibility
4942
# Run unit tests to help check for any behavior differences (dependant on coverage)
50-
mvn compile -B -V -ntp \
43+
mvn test -B -V -ntp \
5144
-Dclirr.skip=true \
5245
-Denforcer.skip=true \
5346
-Dmaven.javadoc.skip=true \

0 commit comments

Comments
 (0)