Skip to content

Commit 3418b1f

Browse files
committed
chore: Address PR feedback
1 parent 271ae00 commit 3418b1f

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

.github/workflows/dependency_compatibility_test.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ jobs:
3232
- name: Determine Inputted Dependencies List
3333
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.dependencies-list != '' }}
3434
run: echo "DEPENDENCIES_LIST=${{ github.event.inputs.dependencies-list }}" >> $GITHUB_ENV
35-
# Install the modules for the rest of the CI
36-
- name: Install sdk-platform-java's modules
37-
# gapic-generator-java requires Java 8 and is irrelevant for this CI
38-
run: mvn -q -B -ntp install --projects '!gapic-generator-java' -Dcheckstyle.skip -Dfmt.skip -DskipTests -Dclirr.skip -T 1C
3935

4036
# Run in the root module which should test for everything except for showcase
4137
- name: Perform Dependency Compatibility Testing
@@ -59,6 +55,11 @@ jobs:
5955
tar -xf showcase-*
6056
./gapic-showcase run &
6157
cd -
58+
59+
# Install the modules for showcase (Shared-Deps is required to run showcase)
60+
- name: Install sdk-platform-java's modules
61+
# gapic-generator-java requires Java 8 and is irrelevant for this CI
62+
run: mvn -q -B -ntp install --projects '!gapic-generator-java' -Dcheckstyle.skip -Dfmt.skip -DskipTests -Dclirr.skip -T 1C
6263
# Run specifically for showcase
6364
- name: Perform Dependency Compatibility Testing (Showcase only)
6465
shell: bash

dependencies.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# "1P" refers to First-Party dependencies (owned by Google).
44
# "3P" refers to Third-Party dependencies.
55

6-
# 1P Parent-Pom
6+
# Pom-Parent Dependencies (https://github.com/googleapis/sdk-platform-java/blob/main/gapic-generator-java-pom-parent/pom.xml)
77
javax.annotation-api=1.3.2
88
grpc=1.74.0
99
google.auth=1.37.1
@@ -17,12 +17,12 @@ j2objc-annotations=3.0.0
1717
threetenbp=1.7.1
1818
slf4j=2.0.17
1919

20-
# 1P Shared-Deps
20+
# 1P Shared-Deps (https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/first-party-dependencies/pom.xml)
2121
grpc-gcp=1.6.1
2222
google.oauth-client=1.39.0
2323
google.api-client=2.8.0
2424

25-
# 3P Shared-Deps
25+
# 3P Shared-Deps (https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/third-party-dependencies/pom.xml)
2626
threeten-extra=1.8.0
2727
opencensus=0.31.0
2828
findbugs=3.0.2

0 commit comments

Comments
 (0)